Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

urlencode redirection url in auth endpoint generation #42

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

hi there,

for web authentication, in the authentication endpoint, I think we would like the redirect_uri parameter to be urlencoded. for example, if the client id is "abc" and redirect_uri is "http://localhost/callback" the authatication endpoint should be:

https://login.live.com/oauth20_authorize.srf?client_id=abc&scope=bingads.manage&response_type=code&redirect_uri=http%3A%2F%2Flocalhost%2Fcallback

instead of

https://login.live.com/oauth20_authorize.srf?client_id=abc&scope=bingads.manage&response_type=code&redirect_uri=http://localhost/callback

let me know if there are any problems/questions with this. thanks!

Contributor

imagineful commented Dec 20, 2016

Thanks for your feedback, we will consider to make the change in next release.

Thanks very much!

(it might be worth pointing out this is actually a tiny Pull Request which intend to address the aforementioned issue. I wasn't sure it was clear originally, thanks again!)

Contributor

imagineful commented Dec 30, 2016

Hi, Teelee, we have released version 10.4.11 with your pull request merged. (while we don't merge the code on Github directly)
Thanks for your request and feedback.

thanks for the release!

@teelee7133 teelee7133 closed this Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment