Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
urlencode redirection url in auth endpoint generation #42
Conversation
|
Thanks for your feedback, we will consider to make the change in next release. |
teelee7133
commented
Dec 20, 2016
|
Thanks very much! (it might be worth pointing out this is actually a tiny Pull Request which intend to address the aforementioned issue. I wasn't sure it was clear originally, thanks again!) |
|
Hi, Teelee, we have released version 10.4.11 with your pull request merged. (while we don't merge the code on Github directly) |
teelee7133
commented
Jan 3, 2017
|
thanks for the release! |
teelee7133 commentedDec 18, 2016
hi there,
for web authentication, in the authentication endpoint, I think we would like the redirect_uri parameter to be urlencoded. for example, if the client id is "abc" and redirect_uri is "http://localhost/callback" the authatication endpoint should be:
https://login.live.com/oauth20_authorize.srf?client_id=abc&scope=bingads.manage&response_type=code&redirect_uri=http%3A%2F%2Flocalhost%2Fcallback
instead of
https://login.live.com/oauth20_authorize.srf?client_id=abc&scope=bingads.manage&response_type=code&redirect_uri=http://localhost/callback
let me know if there are any problems/questions with this. thanks!