New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TranscodingStreams for FASTA #1

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@BenJWard
Copy link
Member

BenJWard commented Feb 7, 2019

☑️ Checklist

  • 🎨 The changes implemented is consistent with the julia style guide.
  • 📘 I have updated and added relevant docstrings, in a manner consistent with the documentation styleguide.
  • 📘 I have added or updated relevant user and developer manuals/documentation in docs/src/.
  • 🆗 There are unit tests that cover the code changes I have made.
  • 🆗 The unit tests cover my code changes AND they pass.
  • 📝 I have added an entry to the [UNRELEASED] section of the manually curated CHANGELOG.md file for this repository.
  • 🆗 All changes should be compatible with the latest stable version of Julia.
  • 💭 I have commented liberally for any complex pieces of internal code.

biojulia-bors bot added a commit that referenced this pull request Feb 7, 2019

biojulia-bors bot added a commit that referenced this pull request Feb 7, 2019

Merge #1
1: Use TranscodingStreams for FASTA r=BenJWard a=BenJWard

## ☑️ Checklist

- [x] 🎨 The changes implemented is consistent with the [julia style guide](https://docs.julialang.org/en/stable/manual/style-guide/).
- [x] 📘 I have updated and added relevant docstrings, in a manner consistent with the [documentation styleguide](https://docs.julialang.org/en/stable/manual/documentation/).
- [x] 📘 I have added or updated relevant user and developer manuals/documentation in `docs/src/`.
- [x] 🆗 There are unit tests that cover the code changes I have made.
- [x] 🆗 The unit tests cover my code changes AND they pass.
- [x] 📝 I have added an entry to the `[UNRELEASED]` section of the manually curated `CHANGELOG.md` file for this repository.
- [x] 🆗 All changes should be compatible with the latest stable version of Julia.
- [x] 💭 I have commented liberally for any complex pieces of internal code.


Co-authored-by: Ben J. Ward <benjward@protonmail.com>

biojulia-bors bot added a commit that referenced this pull request Feb 7, 2019

@BioJulia BioJulia deleted a comment from biojulia-bors bot Feb 7, 2019

@BioJulia BioJulia deleted a comment from biojulia-bors bot Feb 7, 2019

@BioJulia BioJulia deleted a comment from biojulia-bors bot Feb 7, 2019

@BenJWard

This comment has been minimized.

Copy link
Member Author

BenJWard commented Feb 7, 2019

bors try

biojulia-bors bot added a commit that referenced this pull request Feb 7, 2019

@biojulia-bors

This comment has been minimized.

Copy link

biojulia-bors bot commented Feb 7, 2019

try

Build succeeded

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 9, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@967d919). Click here to learn what that means.
The diff coverage is 43.75%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master      #1   +/-   ##
========================================
  Coverage          ?   54.5%           
========================================
  Files             ?       9           
  Lines             ?     411           
  Branches          ?       0           
========================================
  Hits              ?     224           
  Misses            ?     187           
  Partials          ?       0
Impacted Files Coverage Δ
src/fasta/readrecord.jl 28.94% <28.94%> (ø)
src/fasta/reader.jl 65.62% <65.38%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967d919...ba0af74. Read the comment docs.

@BenJWard BenJWard force-pushed the redesign branch from 9ff9809 to 682c5f6 Feb 9, 2019

BenJWard added some commits Feb 4, 2019

@BenJWard BenJWard force-pushed the redesign branch from 49c7c42 to 13a2712 Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment