From bc0a1c7cf25b4d61653cd8a426b485fb77734237 Mon Sep 17 00:00:00 2001 From: Robert Haines Date: Tue, 11 Nov 2014 19:00:48 +0000 Subject: [PATCH] Fix embedded iframe problem with PDF outputs. The iframe tag is a "content tag" and must have an explicit closing tag. This was causing outputs listed after an inlined PDF to not show up. See: https://jira.biovel.eu/browse/TAV-527 --- lib/taverna_player_renderers.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/taverna_player_renderers.rb b/lib/taverna_player_renderers.rb index 0add973952..56562edc3b 100644 --- a/lib/taverna_player_renderers.rb +++ b/lib/taverna_player_renderers.rb @@ -46,10 +46,10 @@ def format_xml(port, index = []) end def inline_pdf(port, index = []) - "If you do not see the PDF document displayed in the browser below, "\ - "please download it (using the button above) and load it into a PDF "\ - "reader application on your local machine.
" + - tag(:iframe, :src => port.path(index), :class => "inline_pdf") + "If you do not see the PDF document displayed in the browser below, please + download it (using the button above) and load it into a PDF reader + application on your local machine.
" + + content_tag(:iframe, nil, :src => port.path(index), :class => "inline_pdf") end def format_error(port, index = [])