New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coMethDMR #2064
Comments
Hi @fveitz Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
|
Dear Bioconductor Review Team, |
A reviewer has been assigned to your package. Learn what to expect IMPORTANT: Please read this documentation for setting Bioconductor utilized your github ssh-keys for git.bioconductor.org |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "TIMEOUT, skipped". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: 52490ece613295f9734d6fabb892e5b2be0237e2 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
@fveitz - Thank you for working on your package to get it ready for review. Please keep in mind that the deadline to accept new packages into the Bioconductor 3.13 release is May 12th. Any packages accepted after this date will be included in the next release. Best, |
Hi @Kayla-Morrell! The data files in Should we ask you for help with this? |
We have moved the example data sets to a supplemental GitHub directory. The package now has an install size <5Mb. We will be pushing these changes upstream tomorrow morning. |
Hi @Kayla-Morrell, |
Hello @gabrielodom - Thank you for reaching out. I believe @nturaga should be able to help with this. Best, |
Hi,
Please send an email as instructed to ***@***.******@***.***> . We like to keep a track of packages when we manually interfere and make big changes like this, for the purpose of back tracing if needed.
Best,
Nitesh
From: Kayla-Morrell ***@***.***>
Date: Thursday, May 6, 2021 at 9:23 AM
To: Bioconductor/Contributions ***@***.***>
Cc: Nitesh Turaga ***@***.***>, Mention ***@***.***>
Subject: Re: [Bioconductor/Contributions] coMethDMR (#2064)
Hello @gabrielodom<https://github.com/gabrielodom> - Thank you for reaching out. I believe @nturaga<https://github.com/nturaga> should be able to help with this.
Best,
Kayla
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#2064 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAU6QS3PU6SL27RZD2U6XLDTMKJ4BANCNFSM43K6PDMQ>.
|
Hi @nturaga, |
Received a valid push on git.bioconductor.org; starting a build for commit id: ae98b938139084353628b9a69c436c56853c8d78 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
We have extracted and documented the NOTEs here: TransBioInfoLab/coMethDMR#1. |
Received a valid push on git.bioconductor.org; starting a build for commit id: aa0c6ac3be74752f8348c56c998314d86489345f |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Hi @Kayla-Morrell, |
@fveitz - Thank you for submitting to Bioconductor. Please see the initial review of DESCRIPTION
Vignettesvin1_Introduction_to_coMethDMR_geneBasedPipeline
This makes the rest of the vignette almost non-reproducable since objects aren't found.
vin2_BiocParallel_for_coMethDMR_geneBasedPipeline
Unit tests
R code
Best, |
Received a valid push on git.bioconductor.org; starting a build for commit id: 76736cb40cf4dd756915cb6d7de9292d08aae290 |
Thank you Lori and Nitesh! Fernanda, please try this as soon as possible. |
Received a valid push on git.bioconductor.org; starting a build for commit id: 3e1e22cf98528d23c1a5c5ebad0087b21c00e538 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Hi Lori, Nitesh and Gabriel,
Using my internet at home I could push successfully.
"Fernandas-MacBook-Pro:coMethDMR fernandaveitzman$ git push upstream master
Enumerating objects: 179, done.
Counting objects: 100% (179/179), done.
Delta compression using up to 16 threads
Compressing objects: 100% (128/128), done.
Writing objects: 100% (128/128), 32.08 KiB | 290.00 KiB/s, done.
Total 128 (delta 104), reused 0 (delta 0)
remote: Resolving deltas: 100% (104/104), completed with 48 local objects.
To git.bioconductor.org:packages/coMethDMR.git
507e5d3..3e1e22c master -> master"
Thank you!
…On Thu, Oct 21, 2021 at 10:50 AM Gabriel J. Odom ***@***.***> wrote:
Thank you Lori and Nitesh! Fernanda, please try this as soon as possible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2064 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASCHHMX5UJA34OL4DO6FVDDUIASCDANCNFSM43K6PDMQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
And we have another build error. Give us a minute. I think it's the sesameData package again. |
Received a valid push on git.bioconductor.org; starting a build for commit id: 64f54b826f1713142814afab2a93c38cdfe0b126 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: 1edd8558764f32bd1425c5f9aced233af0bc8d68 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
Were you ready for a re-review? |
@lshep -- if you have time. We aren't in a huge hurry (the paper was already accepted), and we know you have a million other things. |
In vin1 section 2.3. I still cannot reproduce your results.After the run
|
@lshep, I know this is a huge ask, but do you have time for a Zoom call? We have tried everything we can think of to replicate this error, but to no avail. |
That can be arranged. When were you thinking? |
Our time is yours to command. I have @fveitz in my office at this instant |
I'm free now if you wanted to set up a zoom and email me or slack me the information to login |
Setting it up now |
I sent it to the roswell park email. Is that still ok? |
Received a valid push on git.bioconductor.org; starting a build for commit id: 5762fddc9c20815a94120212991d81448df0393b |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on Linux, Mac, and Windows. Congratulations! The package built without errors or warnings Please see the build report for more details. This link will be active Remember: if you submitted your package after July 7th, 2020, |
@lshep, we have fixed the issue, and the build passes (see above). |
Your package has been accepted. It will be added to the Thank you for contributing to Bioconductor! Reviewers for Bioconductor packages are volunteers from the Bioconductor |
The master branch of your GitHub repository has been added to Bioconductor's git repository. To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/fveitz.keys is not empty), then no further steps are required. Otherwise, do the following: See further instructions at https://bioconductor.org/developers/how-to/git/ for working with this repository. See especially https://bioconductor.org/developers/how-to/git/new-package-workflow/ to keep your GitHub and Bioconductor repositories in sync. Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at https://bioconductor.org/checkResults/ (Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using https://bioconductor.org/packages/coMethDMR If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further. |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Dear reviewer, I am submitting my package for the very first time.
I am a master student in the lab of @lxw391 and @gabrielodom
Thank you in advance for your feedback and your patience.
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the Bioconductor code of conduct and
agree to abide by it.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For help with submitting your package, please subscribe and post questions
to the bioc-devel mailing list.
The text was updated successfully, but these errors were encountered: