Make SQLDataFrame a concrete subclass of virtual class DataFrame #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #4 for a discussion of this change.
Starting with S4Vectors 0.33.3, DataFrame is a virtual class with no
listData
,nrows
, orrownames
slot, making it possible for SQLDataFrame to become a concrete subclass of DataFrame.The ultimate goal is to be able to use an SQLDataFrame object in any place where a DataFrame derivative is expected. For example inside a Vector derivative to store the metadata columns, or inside a SummarizedExperiment derivative to store the colData. With SQLDataFrame 1.9.1, this is now possible but with a big gotcha:
Looks good... BUT:
Basically, this fails because SQLDataFrame objects don't support
rownames<-
:Supporting
rownames<-
would go a long way in making SQLDataFrame objects drop-in replacements for DFrame objects.H.