Update address sync tool to include data access policy selection

[andrewvanbreda]

Update address sync tool to include data access policy selection

[andrewvanbreda]

Awaiting email response about urgency from Oli before committing.

Note to AVB: To get this to work, don't forget to create a person_attribute on the warehouse, but must be type text even though it is a boolean on drupal

AVB Response:
Attribute already exists (13). Added required configuration to sync page. Now just need the code on the site.

[andrewvanbreda]

Confirmed: Proceed with trying to get this out with the latest batch of fixes possibly using a hotfix because an indicia release has already been made.

[andrewvanbreda]

Submitted this to JVB to release after checking.

[andrewvanbreda]

Note to AVB: Also include checkbox on report page

AVB Response: This is all committed and ready to go live

[andrewvanbreda]

AVB: Not currently working on training site when it should be working.
Looks like the latest code isn't there, at least not for the splash_extensions.php file, although other things do seem to be working, so it is a bit confusing. Pretty sure splash_extensions.php isn't up to date with the master branch
@BirenRathod Any ideas?

[BirenRathod]

@andrewvanbreda

I got code from drupal7_client_helpers repository, if it hasn't committed there than there must be something missing here.

[BirenRathod]

Sorry it is drupal7_iform repository.

[BirenRathod]

Hello @andrewvanbreda

Here is the splash_extension.php, file deployed from drupal7_iform repository.

splash_extensions.zip

[andrewvanbreda]

Hi @BirenRathod ,

That file seems to be missing the changes for some reason,
But they can be seen here
https://github.com/Indicia-Team/client_helpers/blob/master/prebuilt_forms/extensions/splash_extensions.php

Look at the simple_user_address_upload function, lots of references to the new Data Access Policy code.
Any ideas?

[BirenRathod]

Hello @andrewvanbreda

I checked the commit, you have committed into develop branch but not merge into master branch. If you could do that would be good to go.

[andrewvanbreda]

@BirenRathod I don't understand, pretty sure I did and the change is clearly there in the link above which shows the master code

[BirenRathod]

@andrewvanbreda

Well, than it is not included in drupal7_iform release.

[andrewvanbreda]

@BirenRathod Ahhhh big lightbulb moment. It won't be in the release that you are looking at, as it was an urgent late request that I had to hotfix.
Is it possible to just grab the file from the GitHub master branch and put into onto the training site. That will be the only file you will need to do this for.

[BirenRathod]

@andrewvanbreda
If that file has got all the code what you are after than yes I can do that. I let you know soon once it has done.

[andrewvanbreda]

@BirenRathod Yes it has, it is master branch and that is the only change to that file since the release.
If it goes wrong it isn't an issue as we are doing this to the training site to test it anyway.

[andrewvanbreda]

Jim has moved the file across. Tested on training site and working and now ready for live.

[andrewvanbreda]

Working on live, however the address syncing tool will need running for all users before this issue can be closed

[andrewvanbreda]

Has been run. Issue with timeouts during run has been noted and raised separately. Closing this now.