add EOS token to modulartokenizer #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosheraboh
requested changes
Jun 6, 2023
| @@ -98,7 +98,7 @@ def get_training_corpus(dataset: List) -> Generator: | |||
| print("Fin") | |||
|
|
|||
|
|
|||
| @hydra.main(config_path="./configs", config_name="tokenizer_config", version_base=None) | |||
| @hydra.main(config_path="./configs", config_name="tokenizer_config_personal", version_base=None) | |||
| @@ -0,0 +1,136 @@ | |||
| import hydra | |||
There was a problem hiding this comment.
What is this file? test? script that creates modular tokenizer?
Why is titan relevant here?
| @@ -0,0 +1,46 @@ | |||
| paths: | |||
There was a problem hiding this comment.
any chance we can always use smaller case in variable and files names (including AA and SMILES)
| data: | ||
| tokenizer: | ||
| # modular_tokenizers_out_path: "${paths.tokenizers_path}/modular_wordlevelAA_BPESMILES/" | ||
| overall_max_len: 70 |
There was a problem hiding this comment.
Why do you need to specify the max_len here? We should specify it per task.
| # max_len: 100 # [Optional] max number of tokens to be used by all instances of this tokenizer. If None or undefined, no limit is set. | ||
| start_delimiter: "<start_AA>" | ||
| end_delimiter: "<end_AA>" | ||
| - name: AA |
There was a problem hiding this comment.
What is the difference between AA and AA nonspecial?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.