split multiline message into multiple irc messages #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the irc lib in use doesn't support sending multiline messages. this patch splits messages containing newline characters into multiple irc messgaes to resolve issue: BitBotFactory#565
ghost
added
the
rnevet
approved these changes
Nov 13, 2017
|
Thanks! |
Evanito
pushed a commit
that referenced
this pull request
Jul 20, 2018
* merge upstream (#1) * Plugin Graphs: make history file configurable (#518) * make history file configurable * removed extra paren * Reduce chances of nonce collisions (#520) * Check currency is being analysed before trying to get a rate for it (#528) * Check currency is being analysed before trying to get a rate for it * Fix Capital C in "Lending.py", line 85 (#529) * Resolves Issue 526 (#533) * add dashboard link in navbar * aggregate correct column * Fix recorded data when no rate offers exist, don't print traceback unless ma_debug is on (#531) * Return a dict of all currencies even if balance is 0 (#540) * Log bot "version" on error handling (#543) * When logging an exception also log the number of commits on current branch, will allow to easily identify if reporter is on master and updated. * Move get_git_version to Data module * Change fallback version number to 3.0.0 * A safer approach for handling errors in the git call * Html response fix (#546) * prevent exception overloading when receiving an html response error * prevent unicode from throwing an exception * File log using ensure_ascii * Change min/max daily lend rate depending on exchange (and simplify xdays) (#547) * Change min/max daily lend rate depending on exchange * Lending.py Simplify code with xdays and max/min daily rate * Update Lending.py * Update Lending.py * Bitfinex sync fix (#555) * Sync Bitfinex API requests completely * Update test * Update test * ERR_RATE_LIMIT_fix (#549) * Return a dict of all currencies even if balance is 0 * Sleep and reduce requests per min if we get ERR_RATE_LIMIT * Reduce request window to 1 sec * Move the timers to millisecond resolution in the coach, MA changes times now when it catches 429 * Comments, logs, fix exception * Don't change api request times unless using bitfinex * Update polo coach to milliseconds * Catch 429 at top level and more sensible api_req_period calc * PEP-8 * Unrelated bug I found from ERR_RATE_LIMIT_fix * Sync Bitfinex API requests completely * Update test * Update test * Messed up the merge from bitfinex_sync_fix * Move timer change methods to base class and catch 429 at API level * Add poloniex timer changes * Make sure to re-raise the error, sleep in the MA module not the API. * Converted a tab to spaces * Added Blacklist Option & enforce whitelist (#570) * Added Blacklist Option for Lending * Mistake in Configuration.py * Optimized config description * Optimized description * Minimized api requests by using blacklist_currencies and all_currencies parameter * Removed BTG from all_currencies * Changed to more simple blacklist and changed documentation * Changed default config * Changed configuration description * Addition of a Slack Username parameter as a configuration option. (#576) * Addition of a Slack Username parameter as a configuration option. * Backward compatibility for configs which lack a slack_username * split multiline message into multiple irc messages (#582) the irc lib in use doesn't support sending multiline messages. this patch splits messages containing newline characters into multiple irc messgaes to resolve issue: #565 * Discover minimum amount in EUR (#594) I think this solves #589. * Use docker image with pandas and numpy already installed (#593) * Fixes absolute reference This way the webpage will work even if under a directory, otherwise it redirects to the root directory. * Use FRR on bitfinex as min_daily_rate (#554) * Return a dict of all currencies even if balance is 0 * Sleep and reduce requests per min if we get ERR_RATE_LIMIT * Reduce request window to 1 sec * Move the timers to millisecond resolution in the coach, MA changes times now when it catches 429 * Comments, logs, fix exception * Don't change api request times unless using bitfinex * Update polo coach to milliseconds * Catch 429 at top level and more sensible api_req_period calc * Use FRR for min_daily_rate * Missing from last commit * PEP-8 * Config and docs for frr as min * Use config for frr and use configured min if higher * Unrelated bug I found from ERR_RATE_LIMIT_fix * Unrelated bug I found from ERR_RATE_LIMIT_fix * Sync Bitfinex API requests completely * Update test * Update test * Messed up the merge from bitfinex_sync_fix * Messed up the merge from bitfinex_sync_fix * Move timer change methods to base class and catch 429 at API level * Add poloniex timer changes * Make sure to re-raise the error, sleep in the MA module not the API. * Converted a tab to spaces * Added FRR Delta for Bitfinex * Added FRR Delta for Bitfinex * PEP-8 * Log when using FRR as min daily rate * Allow config to be picked up from 'BOT' section rather than just coin_cfg * Declare variables to allow global access * This is why we should use classes! * exchangeMax needs defined * add larger sleeps to prevent API bans * only display active coins in charts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the irc lib in use doesn't support sending multiline messages. this patch splits messages containing newline characters into multiple irc messgaes to resolve issue: #565
without patching, irc notifications just fail and throw an exception, when messages contain a newline
TESTING STAGE
testing started at 2017-11-13 19:30:00 UTC
no exception thrown at startup (an exception is normally thrown without the patch)
Types of changes
Checklist: