Skip to content

Conversation

@mohammadalfaiyazbitgo
Copy link
Contributor

Ticket: WP-4055

TICKET: WP-4055

Copy link
Contributor

@andrew-scott-fischer andrew-scott-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From WP-4055

adding exclusion for https://github.com/advisories/GHSA-w532-jxjh-hjhjCan't find link , we don’t use jspdf in platform to generate PDFs. PDF generation is done on the client with the sdk.

If we don't use it, why not remove it as a dependency? Ignoring a CVE with an 8.7 score is not a great practice.

@mohammadalfaiyazbitgo
Copy link
Contributor Author

mohammadalfaiyazbitgo commented Mar 19, 2025

From WP-4055

adding exclusion for https://github.com/advisories/GHSA-w532-jxjh-hjhjCan't find link , we don’t use jspdf in platform to generate PDFs. PDF generation is done on the client with the sdk.

If we don't use it, why not remove it as a dependency? Ignoring a CVE with an 8.7 score is not a great practice.

@andrew-scott-fischer The SDK uses it to generate Key cards, but it's on the client end.

@andrew-scott-fischer
Copy link
Contributor

ok, but then you should update the dependency, even if it's a transitive one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants