fix: resolve Node.js 22.18.0 compatibility issues #6766
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace TypeScript import equals syntax with standard ES6 imports - Convert parameter property constructors to standard syntax - Fix fastpriorityqueue import for CommonJS compatibility Resolves CI failures when Node.js 22.x automatically enables experimental TypeScript support and encounters unsupported syntax patterns. Please enter the commit message for your changes. Lines starting TICKET: WP-5599
- Replace ts-node with tsx in mocharc configuration for better Node.js 22.x compatibility - Fix JSON import in deps test to work with module resolution - Add tsx as dev dependency TICKET: WP-5599
- Convert CoinKind, CoinFamily, CoinFeature, and UnderlyingAsset from enums to const objects - Add explicit type casts for array operations to maintain type safety - Update all enum references to use const object pattern - Required for node 22 strip-only mode BREAKING CHANGE: CoinKind, CoinFamily, CoinFeature, and UnderlyingAsset are no longer TypeScript enums. They are now const objects with corresponding type definitions. This requires consumers to update their imports if they were using these as enum types. TICKET: WP-5599
zahin-mohammad
changed the title
zahin-mohammad
changed the title
zahin-mohammad
commented
Aug 20, 2025
| "stream-browserify": "^3.0.0", | ||
| "stream-http": "^3.2.0", | ||
| "terser-webpack-plugin": "^5.3.3", | ||
| "ts-node": "10.8.0", |
Contributor
Author
There was a problem hiding this comment.
We should gradually phase out the use of ts-node. Lots of issues stemming from this with recent node versions and ts-node is not actively maintained anymore.
zahin-mohammad
commented
Aug 20, 2025
| // As returned by https://babylon.nodes.guru/api#/Query/BTCDelegation | ||
| const BtcDelegationResponse = t.type({ btc_delegation: BtcDelegation }, 'BtcDelegationResponse'); | ||
| const filename = __dirname + `/../../../../test/fixtures/babylon/rpc/btc_delegation/testnet.${txid}.json`; | ||
| const filename = __dirname + `/../../fixtures/babylon/rpc/btc_delegation/testnet.${txid}.json`; |
Contributor
Author
There was a problem hiding this comment.
I guess these tests where not running in CI before this? Or at some point have stopped running in CI?
zahin-mohammad
force-pushed
the
WP-5599/fix-node-22-ci
branch
from
c60ee34 to
a498aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit-by-commit.
Note, there is a breaking change in statics (removal of enums).
TICKET: WP-5599