From 0a19d00a7537b82b53100e313e4beb5541d85ebe Mon Sep 17 00:00:00 2001 From: ArunBala-Bitgo Date: Wed, 1 Oct 2025 16:08:48 +0530 Subject: [PATCH] fix: update fullname of binance smart chain and bnb token Ticket: WIN-7449 --- modules/sdk-coin-bsc/test/unit/bsc.ts | 6 +++--- modules/statics/src/allCoinsAndTokens.ts | 4 ++-- modules/statics/src/coins/erc20Coins.ts | 2 +- modules/statics/src/coins/ofcCoins.ts | 11 ++--------- modules/statics/src/coins/ofcErc20Coins.ts | 2 +- 5 files changed, 9 insertions(+), 16 deletions(-) diff --git a/modules/sdk-coin-bsc/test/unit/bsc.ts b/modules/sdk-coin-bsc/test/unit/bsc.ts index 6dd6f2b5c6..6c80d6047b 100644 --- a/modules/sdk-coin-bsc/test/unit/bsc.ts +++ b/modules/sdk-coin-bsc/test/unit/bsc.ts @@ -7,7 +7,7 @@ import { Bsc, Tbsc } from '../../src/index'; const bitgo: TestBitGoAPI = TestBitGo.decorate(BitGoAPI, { env: 'test' }); -describe('Binance Smart Chain', function () { +describe('Native BNB', function () { before(function () { bitgo.safeRegister('bsc', Bsc.createInstance); bitgo.safeRegister('tbsc', Tbsc.createInstance); @@ -21,7 +21,7 @@ describe('Binance Smart Chain', function () { bsc.should.be.an.instanceof(Bsc); bsc.getChain().should.equal('bsc'); bsc.getFamily().should.equal('bsc'); - bsc.getFullName().should.equal('Binance Smart Chain'); + bsc.getFullName().should.equal('Native BNB'); bsc.getBaseFactor().should.equal(1e18); bsc.supportsTss().should.equal(true); bsc.allowsAccountConsolidations().should.equal(true); @@ -33,7 +33,7 @@ describe('Binance Smart Chain', function () { tbsc.should.be.an.instanceof(Tbsc); tbsc.getChain().should.equal('tbsc'); tbsc.getFamily().should.equal('bsc'); - tbsc.getFullName().should.equal('Testnet Binance Smart Chain'); + tbsc.getFullName().should.equal('Testnet Native BNB'); tbsc.getBaseFactor().should.equal(1e18); tbsc.supportsTss().should.equal(true); tbsc.allowsAccountConsolidations().should.equal(true); diff --git a/modules/statics/src/allCoinsAndTokens.ts b/modules/statics/src/allCoinsAndTokens.ts index ae6402991f..54d491f872 100644 --- a/modules/statics/src/allCoinsAndTokens.ts +++ b/modules/statics/src/allCoinsAndTokens.ts @@ -1202,7 +1202,7 @@ export const allCoinsAndTokens = [ account( 'd0d44124-c7e9-4214-96ae-fbc6856ee3c2', 'bsc', - 'Binance Smart Chain', + 'Native BNB', Networks.main.bsc, 18, UnderlyingAsset.BSC, @@ -1212,7 +1212,7 @@ export const allCoinsAndTokens = [ account( '0a205427-f7c9-48a4-a238-c4b33ba6384d', 'tbsc', - 'Testnet Binance Smart Chain', + 'Testnet Native BNB', Networks.test.bsc, 18, UnderlyingAsset.BSC, diff --git a/modules/statics/src/coins/erc20Coins.ts b/modules/statics/src/coins/erc20Coins.ts index e0c4cf4382..ca9f9bbce2 100644 --- a/modules/statics/src/coins/erc20Coins.ts +++ b/modules/statics/src/coins/erc20Coins.ts @@ -992,7 +992,7 @@ export const erc20Coins = [ erc20( '462e1878-68eb-4c2b-9346-cee992195cdc', 'bnb', - 'BNB Token', + 'BNB Token (ETH Network)', 18, '0xb8c77482e45f1f44de1745f52c74426c631bdd52', UnderlyingAsset.BNB diff --git a/modules/statics/src/coins/ofcCoins.ts b/modules/statics/src/coins/ofcCoins.ts index 883591db07..8cf27188d6 100644 --- a/modules/statics/src/coins/ofcCoins.ts +++ b/modules/statics/src/coins/ofcCoins.ts @@ -104,14 +104,7 @@ export const ofcCoins = [ ofc('5958e6e9-c6d7-4372-8d1d-c681f595c481', 'ofchash', 'Provenance', 9, UnderlyingAsset.HASH, CoinKind.CRYPTO), ofc('4616eb4e-9244-449c-a503-02cb2d715b2c', 'ofcsei', 'Sei', 6, UnderlyingAsset.SEI, CoinKind.CRYPTO), ofc('50a00889-47d2-44b5-8dc8-1fb3b4f47b86', 'ofczeta', 'Zeta', 18, UnderlyingAsset.ZETA, CoinKind.CRYPTO), - ofc( - '03df4c0c-12be-4b24-b3c3-c59be198711b', - 'ofcbsc', - 'Binance Smart Chain', - 18, - UnderlyingAsset.BSC, - CoinKind.CRYPTO - ), + ofc('03df4c0c-12be-4b24-b3c3-c59be198711b', 'ofcbsc', 'Native BNB', 18, UnderlyingAsset.BSC, CoinKind.CRYPTO), ofc('7b79bc25-5497-4350-b961-4bbed2bea994', 'ofcsui', 'Sui', 9, UnderlyingAsset.SUI, CoinKind.CRYPTO), ofc('31bae66e-a135-42f9-b9d3-1623ab9c7ecc', 'ofctrx', 'Tron', 6, UnderlyingAsset.TRX, CoinKind.CRYPTO), ofc('dbbceebe-9096-4d7b-ae9e-31eb8a3dc5ca', 'ofcsol', 'Solana', 9, UnderlyingAsset.SOL, CoinKind.CRYPTO), @@ -491,7 +484,7 @@ export const ofcCoins = [ tofc( '52e600bb-b006-452b-9f82-f81c20d0168d', 'ofctbsc', - 'Testnet Binance Smart Chain', + 'Testnet Native BNB', 18, UnderlyingAsset.BSC, CoinKind.CRYPTO diff --git a/modules/statics/src/coins/ofcErc20Coins.ts b/modules/statics/src/coins/ofcErc20Coins.ts index 33e9292e1e..001819f7b6 100644 --- a/modules/statics/src/coins/ofcErc20Coins.ts +++ b/modules/statics/src/coins/ofcErc20Coins.ts @@ -53,7 +53,7 @@ export const ofcErc20Coins = [ ofcerc20('ae72248b-19fb-4736-9430-caf68615a751', 'ofcbal', 'Balancer', 18, UnderlyingAsset.BAL), ofcerc20('8541eeed-0478-45fe-bff9-4bcc63ef3f67', 'ofcbico', 'Biconomy', 18, UnderlyingAsset.BICO), ofcerc20('48e33478-36b0-4332-a792-6b4d629c2376', 'ofcbit', 'BitDAO', 18, UnderlyingAsset.BIT), - ofcerc20('4bc691c4-dcdd-4b78-be96-1e87269c3caf', 'ofcbnb', 'BNB Token', 18, UnderlyingAsset.BNB), + ofcerc20('4bc691c4-dcdd-4b78-be96-1e87269c3caf', 'ofcbnb', 'BNB Token (ETH Network)', 18, UnderlyingAsset.BNB), ofcerc20('7a76184c-b4b2-4c87-81bc-0c496c605488', 'ofcbnt', 'Bancor', 18, UnderlyingAsset.BNT), ofcerc20('f142074d-8d94-442b-a0e3-3f09c98acaeb', 'ofcbtrst', 'Braintrust', 18, UnderlyingAsset.BTRST), ofcerc20('779e9fa5-e4f2-4c74-947a-5b5df61e66df', 'ofcbusd', 'Binance USD', 18, UnderlyingAsset.BUSD, undefined, [