Skip to content

feat(sdk-coin-canton): added memoId check for isValidAddress #7536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borkds merged 1 commit into from
Nov 18, 2025
Merged

feat(sdk-coin-canton): added memoId check for isValidAddress #7536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions modules/sdk-coin-canton/src/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@ export class Utils implements BaseUtils {
isValidAddress(address: string): boolean {
if (!address || address.trim() === '') return false;
const [partyHint, fingerprint] = address.trim().split('::');
if (!partyHint || !fingerprint) return false;
return this.isValidCantonHex(fingerprint);
if (!fingerprint) return false;
// all memoIds are considered valid as long as strings are passed
const [fingerprintPart] = fingerprint.trim().split('?memoId=');
if (!partyHint || !fingerprintPart) return false;
return this.isValidCantonHex(fingerprintPart);
}

/** @inheritdoc */
Expand Down
1 change: 1 addition & 0 deletions modules/sdk-coin-canton/test/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export const CANTON_ADDRESSES = {
INVALID_FINGERPRINT: '12205::12205b4e3537a95126d9060459234gd8ad3c3ddccda4f79901954280ee19c576714d',
MISSING_PARTY_HINT: '::12205b4e3537a95126d9060459234gd8ad3c3ddccda4f79901954280ee19c576714d',
MISSING_FINGERPRINT: '12205::',
VALID_MEMO_ID: '1220a::1220a43d89dc7d8f85316116aac093667f769fce55411aef6846ccb933b2e1a3b598?memoId=1',
};

export const CANTON_BLOCK_HEIGHT = {
Expand Down
6 changes: 6 additions & 0 deletions modules/sdk-coin-canton/test/unit/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,12 @@ describe('Canton Util', function () {
should.exist(isValid);
assert.strictEqual(isValid, false);
});

it('should return true when memo id is valid', function () {
const isValid = utils.isValidAddress(CANTON_ADDRESSES.VALID_MEMO_ID);
should.exist(isValid);
assert.strictEqual(isValid, true);
});
});

describe('Check if block hash is valid', function () {
Expand Down