Skip to content

Conversation

@youngjungithub
Copy link
Contributor

No description provided.

@youngjungithub youngjungithub requested a review from a team as a code owner February 11, 2025 19:13
@youngjungithub youngjungithub self-assigned this Feb 11, 2025
@ericcrosson-bitgo ericcrosson-bitgo marked this pull request as draft February 11, 2025 20:01
@youngjungithub youngjungithub marked this pull request as ready for review February 11, 2025 20:59
@ericcrosson-bitgo ericcrosson-bitgo dismissed andrew-scott-fischer’s stale review February 20, 2025 21:03

Requesting the example be put in the context of api-ts

@ericcrosson-bitgo ericcrosson-bitgo marked this pull request as draft February 20, 2025 21:05
Copy link
Contributor

@vmccarty vmccarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this helps. I mostly just did some editing to the first body of text.

@youngjungithub youngjungithub marked this pull request as ready for review February 25, 2025 21:38
@youngjungithub
Copy link
Contributor Author

@ericcrosson-bitgo Ready for review!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Love it!

},
query: {
q: 'test',
filter:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: this is a great example!

vmccarty
vmccarty previously approved these changes Feb 26, 2025
Copy link
Contributor

@vmccarty vmccarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@youngjungithub youngjungithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on it!

@ericcrosson-bitgo ericcrosson-bitgo marked this pull request as draft February 27, 2025 14:38
Copy link
Contributor

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Thank you, @youngjungithub!

@ericcrosson-bitgo ericcrosson-bitgo marked this pull request as ready for review February 27, 2025 18:43
@ericcrosson-bitgo ericcrosson-bitgo merged commit da24709 into master Feb 27, 2025
5 checks passed
@ericcrosson-bitgo ericcrosson-bitgo deleted the feat/json_parsing branch February 27, 2025 18:44
@github-actions
Copy link

github-actions bot commented Mar 5, 2025

🎉 This PR is included in version @api-ts/openapi-generator@5.7.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@2.0.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@2.0.0-beta.1 🎉

The release is available on npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/typed-express-router@1.1.14 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/express-wrapper@1.0.34 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version @api-ts/superagent-wrapper@1.3.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants