Fix/cart security routes#55
Merged
Merged
Conversation
inmaculadaprisca
approved these changes
May 16, 2026
Contributor
inmaculadaprisca
left a comment
There was a problem hiding this comment.
JWT middleware is properly implemented on the cart routes now. Tested and working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the carrito (shopping cart) endpoints to improve security and user experience by enforcing authentication and ensuring that cart operations are always performed for the authenticated user, rather than relying on client-supplied IDs. The main changes include requiring a valid token for all carrito routes and extracting the user ID from the authenticated token in controller logic.
Authentication and Authorization Improvements:
verificarTokenmiddleware, ensuring only logged-in users can access or modify their cart. (src/routes/carritoRoutes.js, src/routes/carritoRoutes.jsR5-R11)getCarrito,agregarAlCarrito,vaciarCarrito) now extract the user ID from the authenticatedreq.usuario.idinstead of accepting it from request parameters or body, preventing unauthorized access to other users' carts. (src/controllers/carritoController.js, [1] [2]API Endpoint Adjustments:
/carritoinstead of/carrito/:idCliente). (src/routes/carritoRoutes.js, src/routes/carritoRoutes.jsR5-R11)These changes enhance the security and integrity of the carrito functionality by tying all cart operations directly to the authenticated user.