This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[backport#16383 1/3] rpcwallet: default include_watchonly to true for…
… watchonly wallets Summary: The logic before would only include watchonly addresses if it was explicitly set in the rpc argument. This changes the logic like so: If the include_watchonly argument is missing, check the WALLET_FLAG_DISABLE_PRIVATE_KEYS flag to determine if we're working with a watchonly wallet. If so, default include_watchonly to true. If the include_watchonly argument is explicit set to false, we still disable them from the listing. Although this would always return nothing, it might be still useful in situations where you want to explicitly filter out watchonly addresses regardless of what wallet you are dealing with. Signed-off-by: William Casarin <firstname.lastname@example.org> bitcoin/bitcoin@a50d9e6 --- Partial backport of Core [[bitcoin/bitcoin#16383 | PR16383]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7121
- Loading branch information
Showing 1 changed file with 31 additions and 16 deletions.