Skip to content

Commit

Permalink
Build bitcoin-qt with cmake
Browse files Browse the repository at this point in the history
Summary:
The method used is rather byzantine. It basically parse the prl files used for Qt internal build system to figure out dependencies as dependencies for cmake files produced by Qt are incorrect.

The solution come from https://bugreports.qt.io/browse/QTBUG-38913 and, interestingly, is used within QtWebkit.

Test Plan:
  ninja

Check that bitcoin-qt builds.

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1826
  • Loading branch information
deadalnix committed Sep 27, 2018
1 parent 2ff18c6 commit d97f23d
Show file tree
Hide file tree
Showing 3 changed files with 185 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CMakeLists.txt
Expand Up @@ -9,6 +9,9 @@ set(CMAKE_MODULE_PATH
${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules
)

# Make contrib script accessible.
set(CONTRIB_PATH ${CMAKE_CURRENT_SOURCE_DIR}/contrib)

# If ccache is available, then use it.
find_program(CCACHE ccache)
if(CCACHE)
Expand Down
133 changes: 133 additions & 0 deletions contrib/qt/convert-prl-libs-to-cmake.pl
@@ -0,0 +1,133 @@
#!/usr/bin/env perl
# Copyright (C) 2016 Konstantin Tokarev <annulen@yandex.ru>
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
# 1. Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# 2. Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
#
# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
# THE POSSIBILITY OF SUCH DAMAGE.

use File::Basename;
use File::Spec;
use Getopt::Long;
use Text::ParseWords;

use v5.10;

use strict;
use warnings;

my $qt_lib;
my $component_name;
my $out_name;
my $compiler;

processArgs();

sub processArgs {
GetOptions (
"lib=s" => \$qt_lib,
"component=s" => \$component_name,
"out=s" => \$out_name,
"compiler=s" => \$compiler
)
}

my $qt_lib_dir = dirname($qt_lib);
my $qt_lib_base = fileparse($qt_lib, qr{\..*});
my $prl_name = File::Spec->join($qt_lib_dir, "$qt_lib_base.prl");

# Some versions of Qt remove the lib prefix on some plateforms.
if (! -r $prl_name) {
$qt_lib_base =~ s/^lib//;
$prl_name = File::Spec->join($qt_lib_dir, "$qt_lib_base.prl");
}

my $qmake_prl_libs;

open(my $prl, '<', $prl_name) or die "Cannot open $prl_name: $!";
while (<$prl>) {
next unless /^QMAKE_PRL_LIBS/;
chomp;
if (/^QMAKE_PRL_LIBS\s+=\s+(.*)$/) {
$qmake_prl_libs = $1;
last;
}
}
close $prl;

unless ($qmake_prl_libs) {
print "QMAKE_PRL_LIBS variable is undefined or empty\n";
exit;
}

my $prl_libs = squash_prl_libs(shellwords($qmake_prl_libs));

my $template = <<'END_CMAKE';
get_target_property(_link_libs Qt5::${_component} INTERFACE_LINK_LIBRARIES)
if (_link_libs)
set(_list_sep ";")
else ()
set(_list_sep "")
endif ()
set_target_properties(Qt5::${_component} PROPERTIES
"INTERFACE_LINK_LIBRARIES" "${_link_libs}${_list_sep}${_libs}")
set(Qt5${_component}_STATIC_LIB_DEPENDENCIES "${_libs}")
list(APPEND STATIC_LIB_DEPENDENCIES
${Qt5${_component}_STATIC_LIB_DEPENDENCIES}
)
unset(_component)
unset(_libs)
unset(_list_sep)
END_CMAKE

open(my $out, '>>', $out_name) or die "Cannot open $out_name for writing: $!";
print $out qq/set(_component "$component_name")\n/;
print $out qq/set(_libs "$prl_libs")\n/;
print $out qq/set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "$prl_name")\n/;
print $out $template;
close $out;

sub squash_prl_libs {
my @libs = @_;
my @result;
for (my $i = 0; $i < scalar(@libs); ++$i) {
my $lib = $libs[$i];
if ($lib eq '-framework') {
$lib = "$libs[$i] $libs[$i + 1]";
++$i;
}
$lib =~ s"\$\$\[QT_INSTALL_LIBS\]"$qt_lib_dir"g;

if (lc($compiler) eq 'msvc') {
# convert backslashes
$lib =~ s"\\"/"g;

# MSVC doesn't support -L and -l arguments
if ($lib =~ /^-L(.*)$/) {
$lib = "-LIBPATH:$1"
} else {
$lib =~ s/^-l//;
}
}

push @result, $lib;
}
return join ';', @result;
}
50 changes: 49 additions & 1 deletion src/qt/CMakeLists.txt
Expand Up @@ -7,7 +7,51 @@ cmake_policy(SET CMP0071 OLD)

include(BrewHelper)
find_brew_prefix(QT5_PREFIX qt5)
find_package(Qt5 COMPONENTS Widgets Network REQUIRED HINTS "${QT5_PREFIX}")

set(QT_REQUIRED_COMPONENTS Core Widgets Network)
find_package(Qt5 COMPONENTS ${QT_REQUIRED_COMPONENTS} REQUIRED HINTS "${QT5_PREFIX}")

# Find out more about Qt. This is similar to
# http://code.qt.io/cgit/qt/qtwebkit.git/tree/Source/cmake/OptionsQt.cmake
get_target_property(QT_CORE_TYPE Qt5::Core TYPE)
if(QT_CORE_TYPE MATCHES STATIC)
set(QT_STATIC_BUILD ON)
endif()

set(STATIC_DEPENDENCIES_CMAKE_FILE "${CMAKE_BINARY_DIR}/QtStaticDependencies.cmake")
if(EXISTS ${STATIC_DEPENDENCIES_CMAKE_FILE})
file(REMOVE ${STATIC_DEPENDENCIES_CMAKE_FILE})
endif()

set(CONVERT_PRL_PATH "${CONTRIB_PATH}/qt/convert-prl-libs-to-cmake.pl")
macro(CONVERT_PRL_LIBS_TO_CMAKE _qt_component)
if(TARGET Qt5::${_qt_component})
get_target_property(_lib_location Qt5::${_qt_component} LOCATION)
execute_process(COMMAND ${PERL_EXECUTABLE} "${CONVERT_PRL_PATH}"
--lib ${_lib_location}
--out ${STATIC_DEPENDENCIES_CMAKE_FILE}
--component ${_qt_component}
--compiler ${CMAKE_CXX_COMPILER_ID}
)
endif()
endmacro()

if(QT_STATIC_BUILD)
foreach(qt_module ${QT_REQUIRED_COMPONENTS})
CONVERT_PRL_LIBS_TO_CMAKE(${qt_module})
endforeach()
# HACK: We must explicitly add LIB path of the Qt installation
# to correctly find qtpcre
link_directories(${_qt5_install_prefix}/../)

# Now that we generated the dependencies, import them.
set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "${CONVERT_PRL_PATH}")
if(NOT EXISTS ${STATIC_DEPENDENCIES_CMAKE_FILE})
message(FATAL_ERROR "Unable to find ${STATIC_DEPENDENCIES_CMAKE_FILE}")
endif()
include(${STATIC_DEPENDENCIES_CMAKE_FILE})
list(REMOVE_DUPLICATES STATIC_LIB_DEPENDENCIES)
endif()

# Localisation
add_subdirectory(locale)
Expand Down Expand Up @@ -167,3 +211,7 @@ if(BUILD_BITCOIN_WALLET)

target_link_libraries(bitcoin-qt-base wallet)
endif()

# The executable
add_executable(bitcoin-qt bitcoin.cpp)
target_link_libraries(bitcoin-qt bitcoin-qt-base)

0 comments on commit d97f23d

Please sign in to comment.