-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribute case studies to the guide #1022
Contribute case studies to the guide #1022
Conversation
This initial commit is a draft version of the page guiding people on how to commit a case study to the guide. To be added; header images, as well as other images.
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1. Addition of images to this PR as well 2. Change to the title 3. Nav order and next pages
Made some minor corrections to the copy here for readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this page take shape. I left a lot of small comments, hope it's all useful.
Make sure to preview the site on your local dev environment before you commit. When the site is getting built for your preview, it also looks for new images and compresses them. The images in this PR are not compressed and pretty huge. Since they are not primarily flat shapes and lines, JPEG will also be more appropriate for a better compression.
Co-authored-by: Christoph Ono <chri@sto.ph>
Some changes to: - Copy - Previous and next links - Internal linking
…mouxdesign/Guide into feature-contribute-studies-page
Thanks a lot for going through all the code Christoph. I continued to work on it and accepted the copy edits. Also the copy/url ones that I marked as resolved I fixed those in the latest commit in a batch. Still to work on Images. |
Just went through the page. Looks good to me. The only additional thought I had was that it might be nice to have a sample "table of contents" or "structure" in the initial section, which let's the reader quickly get an idea of what a case study should contain, before they dive into the details of the page. Something like: Example structure
|
This commit adds in a table of contents.
Co-authored-by: Christoph Ono <chri@sto.ph>
This commit is to fix some of the images wrt file names and changing them over to jpg format.
File name changes to images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of issues with images, please take another look.
assets/images/guide/contribute/case-studies/casestudy-contribute-custom-image.jpg
Outdated
Show resolved
Hide resolved
assets/images/guide/contribute/case-studies/casestudies-header-mobile@2X.jpg
Outdated
Show resolved
Hide resolved
assets/images/guide/contribute/case-studies/user-persona-example-blixt.jpg
Outdated
Show resolved
Hide resolved
This commit fixes some of the issues with the header and user persona images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Let's get this merged. I think there could be some minor copy improvements, but those can be added in iterations as needed.
This initial commit is a draft version of the page guiding people on how to commit a case study to the guide.
👉 🎉 [Deploy preview]🎉 👈