Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
AddImage button #658
I'm a bit torn on this pull request. On one hand it seems like people would value the feature and displaying the images inline is easy. On the other hand, I am interested in supporting small attachments soon. Attachment support is more general than image support and attachments would likely be more efficiently encoded. My inclination is to hold onto the pull request for the time being.
There are also some moral and political implications of supporting images but not all other attachment types that people are used to which I worry about.
I am undecided just like @Atheros1 , however I am more inclined to accept because my focus is usability. However, there are conflicts and there are UI changes being done. @N0U , I recommend you try the latest UI changes in my forks, https://github.com/mailchuck/PyBitmessage, and try to create a pull request for that one. That will have a better chance of eventually getting into the official PyBitmessage.