New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddImage button #658

Closed
wants to merge 13 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@N0U

N0U commented Apr 6, 2014

Now it is posible to attach an image to a message.
If an image is too big, a user will be asked if the image should be scaled.
All images are coded in base64.

if image.height()*image.width()>300*300:
#Do we need to resize it?
r=QtGui.QMessageBox.question(
self,"Image","This image is to big.\nShould it be scaled?",

This comment has been minimized.

@nimdahk

nimdahk Apr 30, 2014

Use the _Translate function, and that 'to' should be 'too'.

@Atheros1

This comment has been minimized.

Contributor

Atheros1 commented May 19, 2014

I'm a bit torn on this pull request. On one hand it seems like people would value the feature and displaying the images inline is easy. On the other hand, I am interested in supporting small attachments soon. Attachment support is more general than image support and attachments would likely be more efficiently encoded. My inclination is to hold onto the pull request for the time being.

There are also some moral and political implications of supporting images but not all other attachment types that people are used to which I worry about.

@N0U

This comment has been minimized.

N0U commented May 20, 2014

Okay. I will wait for attachment support, because it sounds really nice and much better than base64.
Also, people already attach images, so declining to implement it, because of moral and political reason, would only make attaching images a little bit harder.

@timothyparez

This comment has been minimized.

Contributor

timothyparez commented Mar 27, 2015

I am interested in supporting small attachments

Are we talking about supporting messages in binary format instead of text only?
Allowing BitMessage to serve as a backend for any kind of data exchange, protected
against spam by the PoW of course.

@Atheros1

This comment has been minimized.

Contributor

Atheros1 commented Mar 27, 2015

Yes, that is the goal.

@timothyparez

This comment has been minimized.

Contributor

timothyparez commented Mar 28, 2015

Awesome!

@PeterSurda

This comment has been minimized.

Member

PeterSurda commented Oct 16, 2015

I am undecided just like @Atheros1 , however I am more inclined to accept because my focus is usability. However, there are conflicts and there are UI changes being done. @N0U , I recommend you try the latest UI changes in my forks, https://github.com/mailchuck/PyBitmessage, and try to create a pull request for that one. That will have a better chance of eventually getting into the official PyBitmessage.

@PeterSurda PeterSurda closed this Oct 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment