New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows apps to live separately from the SDK #1154

Closed
andyberry88 opened this Issue Jan 7, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@andyberry88
Member

andyberry88 commented Jan 7, 2015

Once BRJS can be run from the PATH (#1130), allow apps to live separately from the SDK so a single SDK can be used with multiple apps that exist in multiple locations.

@ioanalianabalas

This comment has been minimized.

Show comment
Hide comment
@ioanalianabalas

ioanalianabalas Feb 18, 2015

Contributor

Please see #1231.

Contributor

ioanalianabalas commented Feb 18, 2015

Please see #1231.

@andyberry88

This comment has been minimized.

Show comment
Hide comment
@andyberry88

andyberry88 Mar 18, 2015

Member

Pushing this back into dev as it looks like the FileModificationWatcherThread won't pick up changes in the brjs-apps directory when it doesn't live next to sdk.

public FileModificationWatcherThread(BRJS brjs, WatchKeyServiceFactory watchKeyServiceFactory) throws IOException
        {
                this.watchKeyServiceFactory = watchKeyServiceFactory;
                this.fileModificationRegistry = brjs.getFileModificationRegistry();
                directoryToWatch = brjs.dir().toPath();
                this.brjs = brjs;
        }
Member

andyberry88 commented Mar 18, 2015

Pushing this back into dev as it looks like the FileModificationWatcherThread won't pick up changes in the brjs-apps directory when it doesn't live next to sdk.

public FileModificationWatcherThread(BRJS brjs, WatchKeyServiceFactory watchKeyServiceFactory) throws IOException
        {
                this.watchKeyServiceFactory = watchKeyServiceFactory;
                this.fileModificationRegistry = brjs.getFileModificationRegistry();
                directoryToWatch = brjs.dir().toPath();
                this.brjs = brjs;
        }
@ioanalianabalas

This comment has been minimized.

Show comment
Hide comment
@ioanalianabalas

ioanalianabalas Mar 24, 2015

Contributor

FileModificationWatcherThread won't pick up changes in the brjs-apps directory when it doesn't live next to sdk.

Fixed by #1311.

Contributor

ioanalianabalas commented Mar 24, 2015

FileModificationWatcherThread won't pick up changes in the brjs-apps directory when it doesn't live next to sdk.

Fixed by #1311.

@andyberry88

This comment has been minimized.

Show comment
Hide comment
@andyberry88

andyberry88 Apr 1, 2015

Member

A minor change following the sprint demo:

If I'm running a command inside of an app directory don't require brjs-apps to be present. We need to look at how/if we do this.

Questions:

  • What if the create-app command is run inside of an app directory with no brjs-apps?
  • If serve is run do we just serve up a single app? (I imagine yes)
  • Do we only support this if running commands directly inside of an app or anywhere inside the app?
Member

andyberry88 commented Apr 1, 2015

A minor change following the sprint demo:

If I'm running a command inside of an app directory don't require brjs-apps to be present. We need to look at how/if we do this.

Questions:

  • What if the create-app command is run inside of an app directory with no brjs-apps?
  • If serve is run do we just serve up a single app? (I imagine yes)
  • Do we only support this if running commands directly inside of an app or anywhere inside the app?
@thanhc

This comment has been minimized.

Show comment
Hide comment
@thanhc

thanhc Apr 10, 2015

Contributor

closing this ticket and instead opened #1331 for all remaining issues

Contributor

thanhc commented Apr 10, 2015

closing this ticket and instead opened #1331 for all remaining issues

@thanhc thanhc closed this Apr 10, 2015

@andyberry88 andyberry88 removed the 5 - Test label Apr 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment