Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Static File deployment #18

Closed
3 tasks done
leggetter opened this issue Oct 4, 2013 · 17 comments
Closed
3 tasks done

Support for Static File deployment #18

leggetter opened this issue Oct 4, 2013 · 17 comments
Milestone

Comments

@leggetter
Copy link
Contributor

BRJS currently only supports deployments as WAR files. We need to support deployments in simple flat files for deployment to hosting such as GitHub pages or any CDN.

Related:

@andy-berry-dev andy-berry-dev modified the milestones: v0.4, Planned Backlog Feb 18, 2014
@andy-berry-dev andy-berry-dev modified the milestones: 0.5, v0.4 Mar 5, 2014
@andy-berry-dev andy-berry-dev modified the milestones: 0.6, 0.5 Mar 13, 2014
@andy-berry-dev andy-berry-dev modified the milestones: Planned Backlog, 0.6 Apr 2, 2014
@andy-berry-dev andy-berry-dev added this to the 0.8 milestone Apr 25, 2014
@andy-berry-dev andy-berry-dev modified the milestones: 0.9, 0.8 May 10, 2014
@thecapdan
Copy link
Contributor

following the merge of the flatfile work e338536 , we have problems opening apps from the dashboard due to locale being appended to the appname, e.g.

url requested: http://localhost:7070/dashboard/#apps/myappen/
should be: http://localhost:7070/dashboard/en/#apps/myapp/

@thecapdan
Copy link
Contributor

issue described above is fixed in latest build

@thecapdan
Copy link
Contributor

testing this is blocked by the build-app -w command not working.

Currently throws an exception:

java.io.FileNotFoundException: C:\Users\danielo\Desktop\TESTING\BladeRunnerJS-v0.8-350-g5e4229e\BladeRunnerJS\apps\brjstodo\mobile-aspect\themes\common\aliases.xml

@andy-berry-dev
Copy link
Member

@thecapdan the FileNotFoundException you were seeing should now be gone (fixed in 90e9035).

@thecapdan
Copy link
Contributor

FileNotFoundExcelption fixed + thanks @andyberry88 for sprinkling some magic dust over my test and getting it to pass.

I am now able to get the application running with tomcat.

@thecapdan thecapdan changed the title Support for Flat File deployment Support for Static File deployment Jun 12, 2014
@thecapdan
Copy link
Contributor

Tested static file deployment running on python http server. Tested with different locales

@leggetter
Copy link
Contributor Author

Is the WEB-INF folder "no more"?

@thecapdan
Copy link
Contributor

It still exists for newly created apps - but you can have an app without one

@andy-berry-dev
Copy link
Member

Until we fix #90 and #91 the WEB-INF needs to stay in the app template.

@leggetter
Copy link
Contributor Author

I wouldn't class this as complete until we don't have the WEB-INF. Should this issue be reopened or is this requirement tracked elsewhere?

@andy-berry-dev
Copy link
Member

@leggetter see above comment (I think we commented at the same time). They are the issues tracking the remaining work.

@dchambers
Copy link
Contributor

We are now much closer to finishing this task as it's currently possible to delete an app's 'WEB-INF' directory and still have it broadly work, but there are some remaining items before this task can be closed:

  • Get rid of the SLF4J warnings you currently get if you delete your 'WEB-INF' directory.
  • Make running build-app -w myapp cause a 'WEB-INF' to be added if it's been deleted.
  • Don't create a 'WEB-INF' directory by default.
  • Create a 'j2eeify-app' command that adds in the default 'WEB-INF' directory for those that want to add additional servlets and servlet filters (covered by create a J2eeifyCommandPlugin that allows the WEB-INF folder to be made explicit again #90).
  • Add support for deployment properties files (e.g. 'dev.properties', 'uat.properties', 'prod.properties', etc) that make up for the lack of JNDI when deploying statically.

@andy-berry-dev
Copy link
Member

Closed in error when I closed other issues for the v0.9 release.

@andy-berry-dev
Copy link
Member

The last issues #90 and #91 for this were fixed (and closed) in v0.12.

@dchambers
Copy link
Contributor

@andyberry88, what about my comment:

We are now much closer to finishing this task as it's currently possible to delete an app's 'WEB-INF' directory and still have it broadly work, but there are some remaining items before this task can be closed:

  • Get rid of the SLF4J warnings you currently get if you delete your 'WEB-INF' directory.
  • Make running build-app -w myapp cause a 'WEB-INF' to be added if it's been deleted.
  • Don't create a 'WEB-INF' directory by default.
  • Create a 'j2eeify-app' command that adds in the default 'WEB-INF' directory for those that want to add additional servlets and servlet filters (covered by create a J2eeifyCommandPlugin that allows the WEB-INF folder to be made explicit again #90).
  • Add support for deployment properties files (e.g. 'dev.properties', 'uat.properties', 'prod.properties', etc) that make up for the lack of JNDI when deploying statically.

Are all of these issues done, or have we created new issues for stuff that hasn't been done yet?

@andy-berry-dev
Copy link
Member

@dchambers everything apart from the properties files (the originaly requirements for the issue) have been done. Deployment properties is covered by #749 which is yet to be looked at.

@dchambers
Copy link
Contributor

Thanks @andyberry88 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants