Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Static File deployment #18

Closed
leggetter opened this issue Oct 4, 2013 · 17 comments
Closed

Support for Static File deployment #18

leggetter opened this issue Oct 4, 2013 · 17 comments
Labels
Milestone

Comments

@leggetter
Copy link
Contributor

@leggetter leggetter commented Oct 4, 2013

BRJS currently only supports deployments as WAR files. We need to support deployments in simple flat files for deployment to hosting such as GitHub pages or any CDN.

  • create an export command for flat-file export
  • create a filter so that the bundles can be referred to using their proper extension type, in preparation for flat file export
  • Remove WEB-INF (#90 and #91)

Related:

@andy-berry-dev andy-berry-dev added the S-4 label Feb 18, 2014
@andy-berry-dev andy-berry-dev modified the milestones: v0.4, Planned Backlog Feb 18, 2014
@andy-berry-dev andy-berry-dev modified the milestones: 0.5, v0.4 Mar 5, 2014
@andy-berry-dev andy-berry-dev modified the milestones: 0.6, 0.5 Mar 13, 2014
@andy-berry-dev andy-berry-dev modified the milestones: Planned Backlog, 0.6 Apr 2, 2014
@andy-berry-dev andy-berry-dev added this to the 0.8 milestone Apr 25, 2014
@andy-berry-dev andy-berry-dev added 0 - Backlog and removed size 4 labels Apr 26, 2014
@andy-berry-dev andy-berry-dev modified the milestones: 0.9, 0.8 May 10, 2014
@thecapdan
Copy link
Contributor

@thecapdan thecapdan commented May 28, 2014

following the merge of the flatfile work e338536 , we have problems opening apps from the dashboard due to locale being appended to the appname, e.g.

url requested: http://localhost:7070/dashboard/#apps/myappen/
should be: http://localhost:7070/dashboard/en/#apps/myapp/

@thecapdan
Copy link
Contributor

@thecapdan thecapdan commented May 28, 2014

issue described above is fixed in latest build

@thecapdan
Copy link
Contributor

@thecapdan thecapdan commented Jun 11, 2014

testing this is blocked by the build-app -w command not working.

Currently throws an exception:

java.io.FileNotFoundException: C:\Users\danielo\Desktop\TESTING\BladeRunnerJS-v0.8-350-g5e4229e\BladeRunnerJS\apps\brjstodo\mobile-aspect\themes\common\aliases.xml

@andy-berry-dev
Copy link
Member

@andy-berry-dev andy-berry-dev commented Jun 11, 2014

@thecapdan the FileNotFoundException you were seeing should now be gone (fixed in 90e9035).

@thecapdan
Copy link
Contributor

@thecapdan thecapdan commented Jun 12, 2014

FileNotFoundExcelption fixed + thanks @andyberry88 for sprinkling some magic dust over my test and getting it to pass.

I am now able to get the application running with tomcat.

@thecapdan thecapdan changed the title Support for Flat File deployment Support for Static File deployment Jun 12, 2014
@thecapdan
Copy link
Contributor

@thecapdan thecapdan commented Jun 12, 2014

Tested static file deployment running on python http server. Tested with different locales

@leggetter
Copy link
Contributor Author

@leggetter leggetter commented Jun 13, 2014

Is the WEB-INF folder "no more"?

@thecapdan
Copy link
Contributor

@thecapdan thecapdan commented Jun 13, 2014

It still exists for newly created apps - but you can have an app without one

@andy-berry-dev
Copy link
Member

@andy-berry-dev andy-berry-dev commented Jun 13, 2014

Until we fix #90 and #91 the WEB-INF needs to stay in the app template.

@leggetter
Copy link
Contributor Author

@leggetter leggetter commented Jun 13, 2014

I wouldn't class this as complete until we don't have the WEB-INF. Should this issue be reopened or is this requirement tracked elsewhere?

@andy-berry-dev
Copy link
Member

@andy-berry-dev andy-berry-dev commented Jun 13, 2014

@leggetter see above comment (I think we commented at the same time). They are the issues tracking the remaining work.

@dchambers
Copy link
Contributor

@dchambers dchambers commented Jun 13, 2014

We are now much closer to finishing this task as it's currently possible to delete an app's 'WEB-INF' directory and still have it broadly work, but there are some remaining items before this task can be closed:

  • Get rid of the SLF4J warnings you currently get if you delete your 'WEB-INF' directory.
  • Make running build-app -w myapp cause a 'WEB-INF' to be added if it's been deleted.
  • Don't create a 'WEB-INF' directory by default.
  • Create a 'j2eeify-app' command that adds in the default 'WEB-INF' directory for those that want to add additional servlets and servlet filters (covered by #90).
  • Add support for deployment properties files (e.g. 'dev.properties', 'uat.properties', 'prod.properties', etc) that make up for the lack of JNDI when deploying statically.
@andy-berry-dev
Copy link
Member

@andy-berry-dev andy-berry-dev commented Jun 13, 2014

Closed in error when I closed other issues for the v0.9 release.

@andy-berry-dev andy-berry-dev modified the milestones: 0.10, 0.9 Jun 13, 2014
@andy-berry-dev andy-berry-dev added 0 - Backlog and removed 2 - Dev labels Jun 18, 2014
@andy-berry-dev andy-berry-dev added this to the 0.13 milestone Aug 22, 2014
@andy-berry-dev andy-berry-dev modified the milestones: 0.12, 0.13 Sep 19, 2014
@andy-berry-dev
Copy link
Member

@andy-berry-dev andy-berry-dev commented Sep 19, 2014

The last issues #90 and #91 for this were fixed (and closed) in v0.12.

@dchambers
Copy link
Contributor

@dchambers dchambers commented Sep 19, 2014

@andyberry88, what about my comment:

We are now much closer to finishing this task as it's currently possible to delete an app's 'WEB-INF' directory and still have it broadly work, but there are some remaining items before this task can be closed:

  • Get rid of the SLF4J warnings you currently get if you delete your 'WEB-INF' directory.
  • Make running build-app -w myapp cause a 'WEB-INF' to be added if it's been deleted.
  • Don't create a 'WEB-INF' directory by default.
  • Create a 'j2eeify-app' command that adds in the default 'WEB-INF' directory for those that want to add additional servlets and servlet filters (covered by #90).
  • Add support for deployment properties files (e.g. 'dev.properties', 'uat.properties', 'prod.properties', etc) that make up for the lack of JNDI when deploying statically.

Are all of these issues done, or have we created new issues for stuff that hasn't been done yet?

@andy-berry-dev
Copy link
Member

@andy-berry-dev andy-berry-dev commented Sep 19, 2014

@dchambers everything apart from the properties files (the originaly requirements for the issue) have been done. Deployment properties is covered by #749 which is yet to be looked at.

@dchambers
Copy link
Contributor

@dchambers dchambers commented Sep 19, 2014

Thanks @andyberry88 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.