New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Static File deployment #18

Closed
leggetter opened this Issue Oct 4, 2013 · 17 comments

Comments

Projects
None yet
4 participants
@leggetter
Contributor

leggetter commented Oct 4, 2013

BRJS currently only supports deployments as WAR files. We need to support deployments in simple flat files for deployment to hosting such as GitHub pages or any CDN.

  • create an export command for flat-file export
  • create a filter so that the bundles can be referred to using their proper extension type, in preparation for flat file export
  • Remove WEB-INF (#90 and #91)

Related:

@andyberry88 andyberry88 added the S-4 label Feb 18, 2014

@andyberry88 andyberry88 modified the milestones: v0.4, Planned Backlog Feb 18, 2014

@andyberry88 andyberry88 added 1 - Planned and removed 0 - Backlog labels Feb 18, 2014

@andyberry88 andyberry88 modified the milestones: 0.5, v0.4 Mar 5, 2014

@andyberry88 andyberry88 modified the milestones: 0.6, 0.5 Mar 13, 2014

@andyberry88 andyberry88 modified the milestones: Planned Backlog, 0.6 Apr 2, 2014

@andyberry88 andyberry88 added this to the 0.8 milestone Apr 25, 2014

@andyberry88 andyberry88 added 0 - Backlog and removed size 4 labels Apr 26, 2014

@andyberry88 andyberry88 modified the milestones: 0.9, 0.8 May 10, 2014

@andyberry88 andyberry88 added 1 - Planned and removed 0 - Backlog labels May 12, 2014

@thecapdan

This comment has been minimized.

Show comment
Hide comment
@thecapdan

thecapdan May 28, 2014

Contributor

following the merge of the flatfile work e338536 , we have problems opening apps from the dashboard due to locale being appended to the appname, e.g.

url requested: http://localhost:7070/dashboard/#apps/myappen/
should be: http://localhost:7070/dashboard/en/#apps/myapp/

Contributor

thecapdan commented May 28, 2014

following the merge of the flatfile work e338536 , we have problems opening apps from the dashboard due to locale being appended to the appname, e.g.

url requested: http://localhost:7070/dashboard/#apps/myappen/
should be: http://localhost:7070/dashboard/en/#apps/myapp/

@thecapdan

This comment has been minimized.

Show comment
Hide comment
@thecapdan

thecapdan May 28, 2014

Contributor

issue described above is fixed in latest build

Contributor

thecapdan commented May 28, 2014

issue described above is fixed in latest build

@thecapdan

This comment has been minimized.

Show comment
Hide comment
@thecapdan

thecapdan Jun 11, 2014

Contributor

testing this is blocked by the build-app -w command not working.

Currently throws an exception:

java.io.FileNotFoundException: C:\Users\danielo\Desktop\TESTING\BladeRunnerJS-v0.8-350-g5e4229e\BladeRunnerJS\apps\brjstodo\mobile-aspect\themes\common\aliases.xml

Contributor

thecapdan commented Jun 11, 2014

testing this is blocked by the build-app -w command not working.

Currently throws an exception:

java.io.FileNotFoundException: C:\Users\danielo\Desktop\TESTING\BladeRunnerJS-v0.8-350-g5e4229e\BladeRunnerJS\apps\brjstodo\mobile-aspect\themes\common\aliases.xml

@andyberry88

This comment has been minimized.

Show comment
Hide comment
@andyberry88

andyberry88 Jun 11, 2014

Member

@thecapdan the FileNotFoundException you were seeing should now be gone (fixed in 90e9035).

Member

andyberry88 commented Jun 11, 2014

@thecapdan the FileNotFoundException you were seeing should now be gone (fixed in 90e9035).

@thecapdan

This comment has been minimized.

Show comment
Hide comment
@thecapdan

thecapdan Jun 12, 2014

Contributor

FileNotFoundExcelption fixed + thanks @andyberry88 for sprinkling some magic dust over my test and getting it to pass.

I am now able to get the application running with tomcat.

Contributor

thecapdan commented Jun 12, 2014

FileNotFoundExcelption fixed + thanks @andyberry88 for sprinkling some magic dust over my test and getting it to pass.

I am now able to get the application running with tomcat.

@thecapdan thecapdan changed the title from Support for Flat File deployment to Support for Static File deployment Jun 12, 2014

@thecapdan

This comment has been minimized.

Show comment
Hide comment
@thecapdan

thecapdan Jun 12, 2014

Contributor

Tested static file deployment running on python http server. Tested with different locales

Contributor

thecapdan commented Jun 12, 2014

Tested static file deployment running on python http server. Tested with different locales

@leggetter

This comment has been minimized.

Show comment
Hide comment
@leggetter

leggetter Jun 13, 2014

Contributor

Is the WEB-INF folder "no more"?

Contributor

leggetter commented Jun 13, 2014

Is the WEB-INF folder "no more"?

@thecapdan

This comment has been minimized.

Show comment
Hide comment
@thecapdan

thecapdan Jun 13, 2014

Contributor

It still exists for newly created apps - but you can have an app without one

Contributor

thecapdan commented Jun 13, 2014

It still exists for newly created apps - but you can have an app without one

@andyberry88

This comment has been minimized.

Show comment
Hide comment
@andyberry88

andyberry88 Jun 13, 2014

Member

Until we fix #90 and #91 the WEB-INF needs to stay in the app template.

Member

andyberry88 commented Jun 13, 2014

Until we fix #90 and #91 the WEB-INF needs to stay in the app template.

@leggetter

This comment has been minimized.

Show comment
Hide comment
@leggetter

leggetter Jun 13, 2014

Contributor

I wouldn't class this as complete until we don't have the WEB-INF. Should this issue be reopened or is this requirement tracked elsewhere?

Contributor

leggetter commented Jun 13, 2014

I wouldn't class this as complete until we don't have the WEB-INF. Should this issue be reopened or is this requirement tracked elsewhere?

@andyberry88

This comment has been minimized.

Show comment
Hide comment
@andyberry88

andyberry88 Jun 13, 2014

Member

@leggetter see above comment (I think we commented at the same time). They are the issues tracking the remaining work.

Member

andyberry88 commented Jun 13, 2014

@leggetter see above comment (I think we commented at the same time). They are the issues tracking the remaining work.

@leggetter leggetter reopened this Jun 13, 2014

@dchambers

This comment has been minimized.

Show comment
Hide comment
@dchambers

dchambers Jun 13, 2014

Contributor

We are now much closer to finishing this task as it's currently possible to delete an app's 'WEB-INF' directory and still have it broadly work, but there are some remaining items before this task can be closed:

  • Get rid of the SLF4J warnings you currently get if you delete your 'WEB-INF' directory.
  • Make running build-app -w myapp cause a 'WEB-INF' to be added if it's been deleted.
  • Don't create a 'WEB-INF' directory by default.
  • Create a 'j2eeify-app' command that adds in the default 'WEB-INF' directory for those that want to add additional servlets and servlet filters (covered by #90).
  • Add support for deployment properties files (e.g. 'dev.properties', 'uat.properties', 'prod.properties', etc) that make up for the lack of JNDI when deploying statically.
Contributor

dchambers commented Jun 13, 2014

We are now much closer to finishing this task as it's currently possible to delete an app's 'WEB-INF' directory and still have it broadly work, but there are some remaining items before this task can be closed:

  • Get rid of the SLF4J warnings you currently get if you delete your 'WEB-INF' directory.
  • Make running build-app -w myapp cause a 'WEB-INF' to be added if it's been deleted.
  • Don't create a 'WEB-INF' directory by default.
  • Create a 'j2eeify-app' command that adds in the default 'WEB-INF' directory for those that want to add additional servlets and servlet filters (covered by #90).
  • Add support for deployment properties files (e.g. 'dev.properties', 'uat.properties', 'prod.properties', etc) that make up for the lack of JNDI when deploying statically.
@andyberry88

This comment has been minimized.

Show comment
Hide comment
@andyberry88

andyberry88 Jun 13, 2014

Member

Closed in error when I closed other issues for the v0.9 release.

Member

andyberry88 commented Jun 13, 2014

Closed in error when I closed other issues for the v0.9 release.

@andyberry88 andyberry88 reopened this Jun 13, 2014

@andyberry88 andyberry88 added this to the 0.10 milestone Jun 13, 2014

@andyberry88 andyberry88 modified the milestones: 0.9, 0.10 Jun 13, 2014

@andyberry88 andyberry88 added 0 - Backlog and removed 2 - Dev labels Jun 18, 2014

@andyberry88 andyberry88 added this to the 0.13 milestone Aug 22, 2014

@andyberry88 andyberry88 modified the milestones: 0.12, 0.13 Sep 19, 2014

@andyberry88

This comment has been minimized.

Show comment
Hide comment
@andyberry88

andyberry88 Sep 19, 2014

Member

The last issues #90 and #91 for this were fixed (and closed) in v0.12.

Member

andyberry88 commented Sep 19, 2014

The last issues #90 and #91 for this were fixed (and closed) in v0.12.

@dchambers

This comment has been minimized.

Show comment
Hide comment
@dchambers

dchambers Sep 19, 2014

Contributor

@andyberry88, what about my comment:

We are now much closer to finishing this task as it's currently possible to delete an app's 'WEB-INF' directory and still have it broadly work, but there are some remaining items before this task can be closed:

  • Get rid of the SLF4J warnings you currently get if you delete your 'WEB-INF' directory.
  • Make running build-app -w myapp cause a 'WEB-INF' to be added if it's been deleted.
  • Don't create a 'WEB-INF' directory by default.
  • Create a 'j2eeify-app' command that adds in the default 'WEB-INF' directory for those that want to add additional servlets and servlet filters (covered by #90).
  • Add support for deployment properties files (e.g. 'dev.properties', 'uat.properties', 'prod.properties', etc) that make up for the lack of JNDI when deploying statically.

Are all of these issues done, or have we created new issues for stuff that hasn't been done yet?

Contributor

dchambers commented Sep 19, 2014

@andyberry88, what about my comment:

We are now much closer to finishing this task as it's currently possible to delete an app's 'WEB-INF' directory and still have it broadly work, but there are some remaining items before this task can be closed:

  • Get rid of the SLF4J warnings you currently get if you delete your 'WEB-INF' directory.
  • Make running build-app -w myapp cause a 'WEB-INF' to be added if it's been deleted.
  • Don't create a 'WEB-INF' directory by default.
  • Create a 'j2eeify-app' command that adds in the default 'WEB-INF' directory for those that want to add additional servlets and servlet filters (covered by #90).
  • Add support for deployment properties files (e.g. 'dev.properties', 'uat.properties', 'prod.properties', etc) that make up for the lack of JNDI when deploying statically.

Are all of these issues done, or have we created new issues for stuff that hasn't been done yet?

@andyberry88

This comment has been minimized.

Show comment
Hide comment
@andyberry88

andyberry88 Sep 19, 2014

Member

@dchambers everything apart from the properties files (the originaly requirements for the issue) have been done. Deployment properties is covered by #749 which is yet to be looked at.

Member

andyberry88 commented Sep 19, 2014

@dchambers everything apart from the properties files (the originaly requirements for the issue) have been done. Deployment properties is covered by #749 which is yet to be looked at.

@dchambers

This comment has been minimized.

Show comment
Hide comment
@dchambers

dchambers Sep 19, 2014

Contributor

Thanks @andyberry88 👍

Contributor

dchambers commented Sep 19, 2014

Thanks @andyberry88 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment