-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Static File deployment #18
Comments
following the merge of the flatfile work e338536 , we have problems opening apps from the dashboard due to locale being appended to the appname, e.g. url requested: http://localhost:7070/dashboard/#apps/myappen/ |
issue described above is fixed in latest build |
testing this is blocked by the build-app -w command not working. Currently throws an exception: java.io.FileNotFoundException: C:\Users\danielo\Desktop\TESTING\BladeRunnerJS-v0.8-350-g5e4229e\BladeRunnerJS\apps\brjstodo\mobile-aspect\themes\common\aliases.xml |
@thecapdan the FileNotFoundException you were seeing should now be gone (fixed in 90e9035). |
FileNotFoundExcelption fixed + thanks @andyberry88 for sprinkling some magic dust over my test and getting it to pass. I am now able to get the application running with tomcat. |
Tested static file deployment running on python http server. Tested with different locales |
Is the |
It still exists for newly created apps - but you can have an app without one |
I wouldn't class this as complete until we don't have the |
@leggetter see above comment (I think we commented at the same time). They are the issues tracking the remaining work. |
We are now much closer to finishing this task as it's currently possible to delete an app's 'WEB-INF' directory and still have it broadly work, but there are some remaining items before this task can be closed:
|
Closed in error when I closed other issues for the v0.9 release. |
@andyberry88, what about my comment:
Are all of these issues done, or have we created new issues for stuff that hasn't been done yet? |
@dchambers everything apart from the properties files (the originaly requirements for the issue) have been done. Deployment properties is covered by #749 which is yet to be looked at. |
Thanks @andyberry88 👍 |
BRJS currently only supports deployments as WAR files. We need to support deployments in simple flat files for deployment to hosting such as GitHub pages or any CDN.
WEB-INF
(create a J2eeifyCommandPlugin that allows the WEB-INF folder to be made explicit again #90 and modify the app template to no longer add 'WEB-INF.xml' and allow the server to add this in programtically #91)Related:
The text was updated successfully, but these errors were encountered: