-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified application directory structure #19
Comments
My vote would probably go with 2 or 4. This means we need to keep the idea of Aspects as a core concept. However, I think it results in the directory structure being clean and related assets being grouped together under a clearly marked directory. I also think that having |
My vote is for 4. As you said above
|
👍
Yes. I believe they should be able to live alongside.
I'm not too keen on the need to include Would it be possible to update the
If three parameters are passed then it creates the blade within the bladeset. |
We can do that but every command would now need to work in 2 different ways and the fact that bladesets are optional is no longer abstracted away. This would also be the same with the API and possibly plugins that now need to understand this new optional structure. |
Not sure what you mean by this. The default becomes creating blades that do not reside within bladesets. Bladesets are more advanced feature and - in terms of the user journey - are only exposed when there becomes a need for it ("If you don't want to move shared assets into a library and you want to share them between related blades then you can use bladesets"). |
OK, I'd assumed they would be optional rather than entirely hidden away. Completely hiding bladesets does make sense so commands should (by default) not require the bladeset name. We need to work out whether we want the API to directly reflect the structure or still have the concept of a |
@leggetter have you had an ideas on tidying up the 'tests' directory structure (#880)? From what I can see there isn't a huge amount of simplification to do after src and test package directories become optional. |
@andyberry88 in the latest
Is this still a work in progress? |
@leggetter it was. It should now be fixed. |
…from e2f0020..b8b2df2 b8b2df2 Merge pull request #19 from bit-shifter/ignore-static-properties-when-verifying-implement 607a0db prevents static properties (i.e. not functions) from causing #implements to fail git-subtree-dir: brjs-sdk/workspace/sdk/libs/javascript/topiarist git-subtree-split: b8b2df23b3b5340a03e0b9297a1044748ceb2fb9
Let's use this space to keep track of the possible options - and final decision. Please add any additional ideas structure ideas here (after discussion, if required).
And use comments to discuss (or a meeting if required).
1. No Default Aspect directory & -blade directories
This is probably more aligned with current simple application structures. The Aspect content is shifted into the root of the app. Blades are in directories in the root of the app with the directories having a suffix of
-blade
(similar to the-aspect
and-bladeset
suffixes).2. Default Aspect directory & -blade directories
3. No Default Aspect directory & blades directory for all Blades
In this example the blades go underneath a
blades
directory. This is consistent with blades that reside within BladeSets.4. Default Aspect directory & blades directory for all Blades
In this example the blades go underneath a
blades
directory. This is consistent with blades that reside within BladeSets.We keep
default-aspect
.Blades Simplified Directory Structure
This is actually issue #80.
The main suggested change here is to
.js
files directly under thesrc
directory to use the blade require prefix (remove the need to repeat the app directory structure).Note: I've left out #880 (simplify tests directory structure) from this.
The text was updated successfully, but these errors were encountered: