Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
#19 contains the discussion about how we'll handle the 'default' bladeset.
As part of this the default for the
Given new users (and probably the majority of OSS users) of BRJS won't use bladesets it would seem sensible to make the default to create the blade without the bladeset and provide a flag to specify whether a bladeset should be used. The command would then look like
Since blades live inside bladesets (the structure is app -> bladeset -> blade) IMO it would be confusing to use the arguments in a different order. The added flag seperates it slightly so its more obvious that's the bladeset.
Hmm, it would be useful to hear others' feedback on this issue.
Whilst I agree that the ordering is unnatural given the resultant directory structure, I don't see that adding the -bset prelude adds any real benefit, and could be considered an annoying necessity if using bladesets in typical development.
As you say, the majority of users would not be using bladesets, so it would be clear to those users (at some point where bladesets become applicable) that the bladeset (optional) name would be the last argument.
This detail would be covered in the command's help in the CLI, so I don't see a reason for concern.
Okay so I'm seeing a fair number of issues with this, here's what the current
Is this the structure we were expecting on disk? (I'm aware there's a separate issue for package structure simplification)
Given the above, here are the results I get when I try and require the
*A: Requiring without bladeset or default in the path *
The source module at 'blades/hawx/src/woop/default/hawx/Enigma.js' is in an invalid location. It's require path starts with the apps require prefix ('woop') which suggests it's require path is intended to be 'woop/hawx'. The require path defined by the source modules location is 'woop/default/hawx'. Either it's package structure should be 'woop/hawx/*' or remove the folders 'woop/default/hawx' to allow the require prefix to be calculated automatically.
require ( 'myapp/default/blade1/Blade1' );
Still no luck, I then change the folder structure of the blade so that it's at the root of the
Still to do
The templates have been updated so they don't include package directories. That was causing the problem where the
This is not specific to this issue. Any exception that is thrown and displayed on a webpage isn't formatted particularly well. Probably needs to be fixed although on the scale of things I'm not sure how high this is on the priority list.
It doesn't affect dependencies or requires. It only affects the require path for Source Modules. There are several new tests in
Tested and verified.