Support additional test runners via TestPlugin #8
Labels
Milestone
Comments
|
#880 (comment) has some info relating to this. |
This was referenced Oct 6, 2014
Closed
andy-berry-dev
pushed a commit
that referenced
this issue
Nov 21, 2014
…anges from 89e36a0..b22f15c b22f15c Merge pull request #8 from adamshone/ie8-compatibility 1573902 IE8 Compatibility: converted the Object#keys() and Object#create() shims into private functionss. This means that browser-modules no longer shims anything. This is important because it must load first in any BRJS app, so anything that it shims cannot be shimmed by code that loads later on, such as the actual es5-shim library. That caused a problem because the Function#bind() shim in browser-modules does not work properly in IE8, whereas the version of Function#bind() in es5-shim does actually work. aae845b IE8 Compatibility: both browser-modules and realm-spec include a Function#bind() shim that does not work in IE8 and also prevents modules that load after this one from shimming #bind(). Fixed by changing both so that they no longer use #bind(). Also had to fix the test setup to check for the existence of the console object before assigning it to origConsole. e44f9cc Added a new 'Fixing Circular Dependencies' section to the browser-modules documentation. 3bc36be Made it obvious that the test within the sub-realms section was for previously introduced code. 3088917 Removing what appears to be Jekyll meta-data from README.md since it was actually visible within the page. 242c7a1 Thouroughly document 'browser-modules' so that people can properly understand how it works. @leggetter, this should be linked into the BRJS documentation. git-subtree-dir: brjs-sdk/workspace/sdk/libs/javascript/browser-modules git-subtree-split: b22f15c
andy-berry-dev
pushed a commit
that referenced
this issue
Apr 7, 2015
IE8 compatibility & remove inline shims
This was referenced Jun 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As covered in the Model & Plugin Design and to facilitate #7 it would be great to support additional
TestPluginimplementations.testcommand so it uses the pluginsWebDrivertest plugin - create a test plugin design that could theoretically support both js-test-driver and webdriver, though for now we won't support webdriver #87WebDriverplugin works with any browser and with absolute paths - WebDriver doesn't support absolute paths to browsers #628The text was updated successfully, but these errors were encountered: