Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing custom EntityViewSetting to spring data repositories #325

Closed
beikov opened this issue Jan 19, 2017 · 4 comments · Fixed by #599

Comments

@beikov
Copy link
Member

commented Jan 19, 2017

Right now, the repositories are bound to a specific entity view type that is defined statically.
Since one of the nice things about entity views is, that the type, filters and sortings can be dynamically defined by the client, we should also allow passing in the entire EntityViewSetting object or maybe even just subsets of it into a repository via parameters.

@Mobe91

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2017

I understand the idea but I think that spring data repositories is very static by nature and I am not sure if there is much to gain for the users if we allow more dynamicity. After all, the user can always fall back to using the CriteriaBuilder directly which provides access to the full set of features. I rather see the spring data integration as a nice tool to quickly have the most commonly used data access methods at hand without writing a lot of code.

@beikov beikov added the spring-data label Feb 21, 2017

@beikov

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2017

As you can see by this user request, the expectation is that there is some support: #350

@beikov beikov added this to the 1.2.0 milestone Feb 21, 2017

@beikov beikov added this to TODO in 1.2.0.Alpha4 Apr 20, 2017

@beikov beikov removed this from TODO in 1.2.0.Alpha4 Oct 31, 2017

@beikov beikov modified the milestones: 1.2.0, 1.3.0, 1.6.0, 1.4.0 Jan 28, 2018

heruan added a commit to heruan/blaze-persistence that referenced this issue Jul 11, 2018
heruan added a commit to heruan/blaze-persistence that referenced this issue Jul 11, 2018
heruan added a commit to heruan/blaze-persistence that referenced this issue Jul 11, 2018
heruan added a commit to heruan/blaze-persistence that referenced this issue Jul 12, 2018
heruan added a commit to heruan/blaze-persistence that referenced this issue Jul 12, 2018
heruan added a commit to heruan/blaze-persistence that referenced this issue Jul 13, 2018

@beikov beikov closed this in #599 Jul 13, 2018

beikov added a commit that referenced this issue Jul 13, 2018

@beikov beikov reopened this Jul 13, 2018

@beikov

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2018

The PR was just a partial fix that added support for @OptionalParam

@beikov

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2018

Superseded by #622

@beikov beikov closed this Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.