Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include constantified expression predicates in pagination object query #711

Closed
beikov opened this issue Dec 20, 2018 · 0 comments · Fixed by #714
Closed

Include constantified expression predicates in pagination object query #711

beikov opened this issue Dec 20, 2018 · 0 comments · Fixed by #714
Assignees
@beikov
Labels
component: core kind: bug
Milestone
1.4.0

Comments

@beikov
Copy link
Member

beikov commented Dec 20, 2018

Description

The optimization for only using the expressions needed for uniqueness for pagination broke a case when we omitted a part of the id due to it being constantified. I'm not entierly sure if we should just include the predicate or if it's better to include the full id in the pagination handling. The latter is the behavior that we had before.

Expected behavior

Actual behavior

Steps to reproduce

Environment

Version: 1.3.0
JPA-Provider:
DBMS:
Application Server:
@beikov beikov added this to the 1.4.0 milestone Dec 20, 2018
@beikov beikov self-assigned this Dec 20, 2018
beikov added a commit to beikov/blaze-persistence that referenced this issue Jan 2, 2019
@beikov
[Blazebit#711] Test and fix for wrong pagination for partly constanti…
dc92521 
…fied embedded id pagination
@beikov beikov mentioned this issue Jan 2, 2019
Merged
beikov added a commit to beikov/blaze-persistence that referenced this issue Jan 2, 2019
@beikov
[Blazebit#711] Test and fix for wrong pagination for partly constanti…
92c749b 
…fied embedded id pagination
beikov added a commit that referenced this issue Jan 3, 2019
@beikov
[#711] Test and fix for wrong pagination for partly constantified emb…
0d638ff 
…edded id pagination
beikov added a commit to beikov/blaze-persistence that referenced this issue Jan 11, 2019
@beikov
[Blazebit#711] Test and fix for wrong pagination for partly constanti…
b99808a 
…fied embedded id pagination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beikov beikov

Labels
component: core kind: bug
Projects
None yet
Milestone
1.4.0
1 participant
@beikov