Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownItem page navigation. #108

Closed
hammie1010 opened this issue Mar 2, 2020 · 5 comments
Closed

DropdownItem page navigation. #108

hammie1010 opened this issue Mar 2, 2020 · 5 comments
Assignees
Labels
bug
Milestone

Comments

@hammie1010
Copy link

@hammie1010 hammie1010 commented Mar 2, 2020

Should the following DropdownItem route to a page component assuming it exists?

<DropdownNavItem Text="Dropdown"> <DropdownItem Text="Item #1" Url="somepage" /> </DropdownNavItem>

@MikaBerglund MikaBerglund self-assigned this Mar 2, 2020
@MikaBerglund

This comment has been minimized.

Copy link
Contributor

@MikaBerglund MikaBerglund commented Mar 2, 2020

Yes it should. Seems that there is a bug that I managed to reproduce in the Showroom application. The "Resources" dropdown menu item to the right is created just like your sample with the difference that it opens in a new tab. The new tab opens, but the link is not loaded.

The code for that main menu is found here. I guess it's pretty much the same as your code?

I'll file this as a bug and set it to be fixed in the first release.

@MikaBerglund MikaBerglund added bug and removed question labels Mar 2, 2020
@MikaBerglund MikaBerglund added this to the v1.0 milestone Mar 2, 2020
@hammie1010

This comment has been minimized.

Copy link
Author

@hammie1010 hammie1010 commented Mar 2, 2020

Yes, that is equivalent. Sounds great - thanks.

MikaBerglund pushed a commit that referenced this issue Mar 2, 2020
@MikaBerglund

This comment has been minimized.

Copy link
Contributor

@MikaBerglund MikaBerglund commented Mar 2, 2020

Was actually quite an easy fix. I already have a PR #109 with the fix for this. I'll process that and publish a fixed Nuget package also. It should be available shortly.

@MikaBerglund

This comment has been minimized.

Copy link
Contributor

@MikaBerglund MikaBerglund commented Mar 2, 2020

The fix to this is now published on Nuget.

@MikaBerglund

This comment has been minimized.

Copy link
Contributor

@MikaBerglund MikaBerglund commented Mar 2, 2020

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.