Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with Node.js 7 on Travis as well #51

Closed
wants to merge 1 commit into from
Closed

Run tests with Node.js 7 on Travis as well #51

wants to merge 1 commit into from

Conversation

nstepien
Copy link

I think I caught some rdkafka error last night when trying to kill a process running with Node 7. Could be completely unrelated.
Either way testing on Node 7 is a good thing.

@webmakersteve
Copy link
Contributor

Hi there:

First I'd like to say thank you very much for your interest in node-rdkafka! Glad to see you're using it on node 7, and I definitely hope it's working well for you.

Unfortunately, while we're happy and willing to accept contributions to fix issues specific to node 7 (provided they do not degrade the experience of our officially supported node versions), adding it to our CI tests would mean we would have to officially support it. We have elected only to support this package on LTS versions of node (i.e., currently, 4 and 6).

With that said, I can't accept the PR at this time. Please feel free to continue reporting issues if they arise as it helps track problems with the project and give insight to others using it.

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants