Return broker error messages for create topic, create partitions #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardocomar
force-pushed
the
admin_error_messages
branch
from
01dd0a9
to
d4d7a08
Compare
On failing to create a Topic or adding partitions, if the broker returns an error message, this is now passed back into the JS error. fixes Blizzard#538 Note : currently librdkafka is returning a fixed error message when create partitions fails, that will being fixed with a separate PR to librdkafka see confluentinc/librdkafka#2154 Co-authored-by: Edoardo Comar <ecomar@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
edoardocomar
force-pushed
the
admin_error_messages
branch
from
d4d7a08
to
f51b951
Compare
|
Looks good to me! Going to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On failing to create a Topic or adding partitions, if the broker returns an error message,
this is now passed back into the JS error.
fixes #538
note : currently
librdkafkais returning a fixed error message when create partitions fails,that will being fixed with a separate PR to
librdkafkasee confluentinc/librdkafka#2154Co-authored-by: Edoardo Comar ecomar@uk.ibm.com
Co-authored-by: Mickael Maison mickael.maison@gmail.com