feat(channels): Slack bot + Telegram allowlist & group @-mention gating#81
Merged
Merged
Conversation
…ion gating - Slack: restore the `slack` command + channel (was uncommitted WIP) and register it in the CLI - Telegram: add TELEGRAM_ALLOWED_USERS allowlist (owner always allowed); in groups only act on @mention or reply-to-bot (mention stripped before the prompt) and ignore other group chatter; private chats unchanged
Code reviewFound 3 issues:
Lines 125 to 129 in 1e7f236
Lines 273 to 284 in 1e7f236
Franklin/src/channel/telegram.ts Lines 200 to 202 in 1e7f236 Franklin/src/channel/telegram.ts Lines 324 to 326 in 1e7f236 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
slackcommand + channel (was uncommitted WIP, nearly lost) and register it in the CLI.TELEGRAM_ALLOWED_USERSallowlist (owner always allowed); in groups only act on @mention or reply-to-bot (mention stripped before the prompt), ignore other group chatter; private chats unchanged.Notes
feat/webui-server(so the diff is just the channels commit). After that merges, this retargets tomain.