From 0dfe2ec1079516d3e75e2aa8662162c44c91ff5a Mon Sep 17 00:00:00 2001 From: Felix Watkins Date: Thu, 12 Oct 2017 11:39:41 +1300 Subject: [PATCH] Update BlockchainLabsNZ_Audit_Report.md --- BlockchainLabsNZ_Audit_Report.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BlockchainLabsNZ_Audit_Report.md b/BlockchainLabsNZ_Audit_Report.md index 2872784..bf1f820 100644 --- a/BlockchainLabsNZ_Audit_Report.md +++ b/BlockchainLabsNZ_Audit_Report.md @@ -60,14 +60,14 @@ The audit report is focused on the following key areas - though this is not an e - Unresolved - **Add README.md outlining contract deployment instructions** - Recommended to add documentation similar to the examples below to increase transparency: ... [View on GitHub](https://github.com/BlockchainLabsNZ/LAToken-Contracts-Audit/issues/13) - Unresolved +- **Add check in harvest method before issuing tokens** - Recommended to add another check in `harvest` method `require(wasNotHarvested >0)` BEFORE token.issueTokens ... [View on GitHub](https://github.com/BlockchainLabsNZ/LAToken-Contracts-Audit/issues/24) + - Unresolved ### Moderate - **SafeMath should be used for all mathematical operations** - Please SafeMath should be used: - [LATokenMinter.sol #113](https://github.com/ElKornacio/contracts-early/blob/199e6a8ce4662f4e3a66e7b689876baea42e665a/LATokenMinter.sol#L113) ... [View on GitHub](https://github.com/BlockchainLabsNZ/LAToken-Contracts-Audit/issues/2) - [x] Fixed [2a85d4b5](https://github.com/ElKornacio/contracts-early/commit/2a85d4b5f63c078dfdaefe6f11a025fe77fb91bb) - **Unable to harvest/exchange unless minter is set to the LATokenMinter contract** - The minter contract address needs to be set as the `minter` to `harvest` or `exchange` but needs to be set to a user's address to burn ... [View on GitHub](https://github.com/BlockchainLabsNZ/LAToken-Contracts-Audit/issues/34) - - Unresolved -- **Add check in harvest method before issuing tokens** - Recommended to add another check in `harvest` method `require(wasNotHarvested >0)` BEFORE token.issueTokens ... [View on GitHub](https://github.com/BlockchainLabsNZ/LAToken-Contracts-Audit/issues/24) - - Unresolved + - [x] Fixed [7fb14b32](https://github.com/BlockchainLabsNZ/LAToken-Contracts-Audit/commit/7fb14b3222aab60e37a6e6fa10b3ef6dca7c2c42) - **Add check for if teamPoolForFrozenTokens has been set** - There is no check if `teamPoolForFrozenTokens` has been set resulting in dangerously being able to mint these tokens into nowhere ... [View on GitHub](https://github.com/BlockchainLabsNZ/LAToken-Contracts-Audit/issues/22) - Unresolved