Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use internal HD wallet for derivation #1

Merged
merged 11 commits into from Jul 17, 2019

Conversation

Projects
None yet
2 participants
@stevenroose
Copy link
Collaborator

commented Jul 11, 2019

TODO:

  • transaction signing

@stevenroose stevenroose force-pushed the stevenroose:own-hd branch 4 times, most recently from 35fb28a to 5aeb0c5 Jul 11, 2019

src/lib.rs Outdated

log::set_max_level(log_filter(log_level));

sess.network = Some(network_name);
sess.wallet = Some(wallet);

// give the first tick
tryit!(sess.tick());

This comment has been minimized.

Copy link
@shesek

shesek Jul 12, 2019

Collaborator

This currently happens only after the user logs in (via GA_session::hello()). This was an intentional choice, but I don't quite remember why :o

This comment has been minimized.

Copy link
@stevenroose

stevenroose Jul 15, 2019

Author Collaborator

I ran into troubles there for the fee estimation test, I think. The test would find empty data because there would not have been a tick. Only non-invasive solution was to wait 5 seconds, but the entire test suite is less than 5 seconds, so that's a bit annoying.

@stevenroose stevenroose referenced this pull request Jul 15, 2019

Merged

Fix unit tests #2

@stevenroose stevenroose force-pushed the stevenroose:own-hd branch 3 times, most recently from fe9edad to 6348814 Jul 15, 2019

stevenroose added some commits Jul 11, 2019

@stevenroose stevenroose force-pushed the stevenroose:own-hd branch from e6f5e1f to 13c33e1 Jul 17, 2019

stevenroose added some commits Jul 17, 2019

@shesek shesek merged commit 57cdefc into Blockstream:master Jul 17, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.