Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: add RpcConfig #34

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@jb55
Copy link
Contributor

commented Sep 27, 2019

This refactor is needed in the future when rpc connections are independent from
the Network itself, in the case where we might want to dynamically detect the
Network.

Signed-off-by: William Casarin jb55@jb55.com

This refactor is needed in the future when rpc connections are independent from
the Network itself, in the case where we might want to dynamically detect the
Network.

Signed-off-by: William Casarin <jb55@jb55.com>
@jb55 jb55 force-pushed the jb55:rpc-config branch from c79fc1f to c8f8876 Sep 28, 2019
pub struct RpcConfig {
pub url: String,
pub cred: Option<(String, String)>, // (username, password)
pub cookie: Option<String>,

This comment has been minimized.

Copy link
@stevenroose

stevenroose Oct 2, 2019

Collaborator

The bitcoincore-rpc crate actually has an enum over these two variants :p It's a nit, though.

@stevenroose stevenroose merged commit b36652d into Blockstream:master Oct 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.