Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More api cleanup #35

Merged
merged 5 commits into from Oct 2, 2019

Conversation

@jb55
Copy link
Contributor

commented Sep 27, 2019

More api cleanup goodness following from #33

I depend on #33 because it needed to be rebased anyways

jb55 added 5 commits Sep 23, 2019
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Let's try to make this library as stateless as possible. Sessions can be managed
directly via the GA_session struct. We should query that periodically for
connectivity instead of having some stateful thing managing multiple sessions.

Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Copy link
Collaborator

left a comment

Just a Q about the android logger. Will probably be necessary to initialize it somewhere else.

debug!("GA_init() config: {:?}", config);

#[cfg(feature = "android_logger")]
INIT_LOGGER.call_once(|| android_log::init("gdk_rpc").unwrap());

This comment has been minimized.

Copy link
@stevenroose

stevenroose Oct 2, 2019

Collaborator

So where is the logger initialized then?

This comment has been minimized.

Copy link
@jb55

jb55 Oct 2, 2019

Author Contributor

thanks! I'll re-add this somewhere

@stevenroose stevenroose merged commit 4333bb8 into Blockstream:master Oct 2, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.