Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-bitcoin to 0.20 #36

Open
wants to merge 1 commit into
base: gdk_integration
from

Conversation

@jb55
Copy link
Contributor

commented Oct 1, 2019

This includes the new Amount apis, etc

I'm merging this into gdk_integration because it has some stuff that still needs to be upstreamed (rust-jsonrpc, rust-bitcoincore-rpc

Signed-off-by: William Casarin jb55@jb55.com

this includes the new Amount apis, etc

Signed-off-by: William Casarin <jb55@jb55.com>
Copy link
Collaborator

left a comment

Why are you removing the liquid-rpc crate?

Also, do you plan to PR the jsonrpc and bitcoincore-rpc changes?

secp256k1 = { version = "0.12", features = [ "rand" ] }
jsonrpc = "0.11"
bitcoin = { version = "0.20", features = [ "use-serde" ] }
bitcoin_hashes = { version = "0.7", features = [ "serde" ] }

This comment has been minimized.

Copy link
@stevenroose

stevenroose Oct 2, 2019

Collaborator

You can remove this one. It's accessible as use bitcoin::hashes::{...}; instead. So you make sure the versions can't get out of sync.

This comment has been minimized.

Copy link
@jb55

jb55 Oct 2, 2019

Author Contributor

good call, I think I remember having issues with this but I could try again...


[dependencies.bitcoincore-rpc]
git = "https://github.com/jb55/rust-bitcoincore-rpc"
rev = "f9eea91f82b3812d0c82810f74edba4259ec6939"

This comment has been minimized.

Copy link
@stevenroose

stevenroose Oct 2, 2019

Collaborator

Please upstream if you have meaningful patches!

[dependencies.liquid-rpc]
git = "https://github.com/stevenroose/rust-liquid-rpc.git"
branch = "master"
optional = true

This comment has been minimized.

Copy link
@stevenroose

stevenroose Oct 2, 2019

Collaborator

Are you dropping Liquid support?

This comment has been minimized.

Copy link
@jb55

jb55 Oct 2, 2019

Author Contributor

ah no it there were many elements serialization issues when I upgraded rust-bitcoin and I didn't get around to fixing it. I have this on my TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.