[5.09.30] Bricked Blast Furnace #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 8, 2017 23:22
Added a new Casing for the Bricked Blast Furnace, GT_Block_Casings4, ID 15 Refactored the non-electric Blast Furnaces: The Bronze Blast Furnace and the Bricked Blast Furnace extend a superclass to ensure consistent behavior. Subclasses only differ in texture, description, and Casing Block.
The Recipe Map is not yet in use.
BrickedBlastFurnace Conflicts: src/main/java/gregtech/api/enums/Materials.java src/main/java/gregtech/api/enums/Textures.java src/main/java/gregtech/common/tileentities/machines/multi/GT_MetaTileEntity_BronzeBlastFurnace.java src/main/java/gregtech/loaders/postload/GT_MachineRecipeLoader.java src/main/java/gregtech/loaders/preload/GT_Loader_MetaTileEntities.java
fixed Glass Hammering consuming 40x more energy than intended Fixed Hammer recipes that (presumably unintentionally) had 10EUt, 16 ticks instead of 16EUt, 10 ticks. Renamed Dense Bricks -> Firebricks
|
There is a complete GT version up for compile with this and the OilRefinery update on my fork of GT5U. |
draknyte1
reviewed
Jun 22, 2017
| } | ||
| ItemStack[] coalStacks = new ItemStack[]{Materials.Coal.getGems(aCoalAmount), Materials.Coal.getDust(aCoalAmount), Materials.Charcoal.getGems(aCoalAmount), Materials.Charcoal.getDust(aCoalAmount)}; | ||
| for (ItemStack coalStack : coalStacks) { | ||
| GT_Recipe.GT_Recipe_Map.sPrimitiveBlastRecipes.addRecipe(true, new ItemStack[]{aInput1, aInput2, coalStack}, new ItemStack[]{aOutput1, aOutput2, Materials.Ash.getDustTiny(aCoalAmount)}, null, null, null, null, aDuration, 0, 0); |
There was a problem hiding this comment.
Normal Coal and Coke produce different types of ash..
draknyte1
reviewed
Jun 22, 2017
| } | ||
|
|
||
| public MetaTileEntity newMetaEntity(IGregTechTileEntity aTileEntity) { | ||
| return new GT_MetaTileEntity_BronzeBlastFurnace(this.mName); |
There was a problem hiding this comment.
The copy-paste mistake
Happens
There was a problem hiding this comment.
Just pointing things out during my review.
draknyte1
requested changes
Jun 22, 2017
There was a problem hiding this comment.
So, 95% of it looks good.
Just be sure to change the things noted and add a config and I see no issues otherwise.
Also be sure the BBF uses the BBF GUI and TE, whilst the bricked one uses the Bricked GUI and TE.
Don't remember which the BBF uses, the diffing is ugh online due to everything having moved a line.
Blast Furnace Recipes using Coal or Charcoal now yield Dark Ash instead of Ash.
Techlone
reviewed
Jun 23, 2017
| @@ -29,7 +29,7 @@ public MetaTileEntity newMetaEntity(IGregTechTileEntity aTileEntity) { | |||
| "Controller Block for the Bricked Blast Furnace", | |||
| "Useable for Steel and general Pyrometallurgy", | |||
| "Size(WxHxD): 3x4x3 (Hollow, with opening on top)", | |||
| "Built from 32 Bricks", | |||
| "Built from 32 Firerick blocks", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a way of rebalancing the Bronze Age I have added a Blast Furnace that is built from bricks.
This eliminates the need to gather large amounts of Bronze for a Bronze Blast Furnace.
The Bricked Blast Furnace has the same structure as the Bronze Blast Furnace and is built from Firebricks.
Firebricks are made from clay, but they require more complex processing than vanilla Bricks.
To build a Bricked Blast Furnace the player needs to build a Steam Compressor and a Steam Hammer/Steam Macerator.
The first Bricked Blast Furnace requires a total of 130 Clay blocks to build.
This is comparable to the 150 Bronze required for a Bronze Blast Furnace, but clay is found much more common than Copper and Tin, therefore reducing the amount of time the player needs to spend on searching for a vein.
On another note, NEI recipes for the primitive blast furnaces have been added.