Skip to content

Conversation

perkinslr
Copy link
Contributor

No description provided.

@Techlone
Copy link
Collaborator

You removed all changes from #536 Why?

@perkinslr
Copy link
Contributor Author

Because I made these changes before #536 got merged and I missed seeing it in my review of what's changed. It wouldn't cleanly apply here, but I just merged what will and reimplemented the non-null check.

@Techlone
Copy link
Collaborator

okay

@Techlone
Copy link
Collaborator

Nonono
Null check not there. I think so that player or something else can destroy block after adding chunk coords data and block will be null. You should write null check after this. tMineBlock != null

@perkinslr
Copy link
Contributor Author

But that block will never be null. It might be Blocks.air, and it might not have a TileEntity, but the block itself will never be null. Unless you're saying that if it is null this pass should automatically move on to the next block in the list... That make sense.

@Blood-Asp Blood-Asp merged commit 315a257 into Blood-Asp:experimental Jun 26, 2016
@Dream-Master
Copy link

Dream-Master commented Jun 26, 2016

Using this code throw out some error.

Error:(142, 72) java: cannot find symbol
  symbol:   variable mle
  location: class gregtech.common.tileentities.machines.multi.GT_MetaTileEntity_AdvMiner2

https://www.dropbox.com/s/pyivj6sjc16om5d/Screenshot%202016-06-26%2021.40.02.png?dl=0

@mura3277
Copy link
Collaborator

The issue is mle is not in the same scope as the methods using it.

@Dream-Master
Copy link

means what? Sorry i am a java noob. How to fix that ?

@mura3277
Copy link
Collaborator

Compare to see the change https://github.com/Muramasa-/GT5-Unofficial/tree/Temp

@Dream-Master
Copy link

@muramasa
like this when i compare both files ?
GTNewHorizons/GT5-Unofficial@3d9a779

@mura3277
Copy link
Collaborator

mura3277 commented Jun 27, 2016

Yep. It's untested of course but it will at least compile. However I can't see there being any issues.

@Dream-Master
Copy link

Ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants