New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Persist the LDAP connection #30

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Meatballs1

Meatballs1 commented Jul 27, 2018

I have even left in my Conncetion typo

@rvazarkar

This comment has been minimized.

Collaborator

rvazarkar commented Jul 29, 2018

I'm surprised this actually works. I was under the impression that the paging would get all sorts of messed up if you did this.

I'm going to do some testing with this to see if its workable

@rvazarkar

This comment has been minimized.

Collaborator

rvazarkar commented Jul 29, 2018

Also, we have to make ldap connections to other domains, so this would definitely break that. Some work will have to be done to make sure that ldap connections for each domain are maintained, instead of just for one.

@Meatballs1

This comment has been minimized.

Meatballs1 commented Jul 29, 2018

Yeah might need to be a bit cleverer if you are doing per domain. I would have thought the paging is per search however.

@rvazarkar

This comment has been minimized.

Collaborator

rvazarkar commented Jul 30, 2018

Did you validate that you get the same amount of data with the connection caching?

@Meatballs1

This comment has been minimized.

Meatballs1 commented Jul 30, 2018

Yes - but I was only doing 'Group' query rather than 'All'.

@rvazarkar

This comment has been minimized.

Collaborator

rvazarkar commented Aug 7, 2018

Implemented in 2.0, thanks @Meatballs1

@rvazarkar rvazarkar closed this Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment