WIP: Persist the LDAP connection #30
Closed
Conversation
Verified
This commit was signed with a verified signature.
|
I'm surprised this actually works. I was under the impression that the paging would get all sorts of messed up if you did this. I'm going to do some testing with this to see if its workable |
|
Also, we have to make ldap connections to other domains, so this would definitely break that. Some work will have to be done to make sure that ldap connections for each domain are maintained, instead of just for one. |
|
Yeah might need to be a bit cleverer if you are doing per domain. I would have thought the paging is per search however. |
|
Did you validate that you get the same amount of data with the connection caching? |
|
Yes - but I was only doing 'Group' query rather than 'All'. |
|
Implemented in 2.0, thanks @Meatballs1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I have even left in my
Conncetiontypo