Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues on trusts collection #61

Merged
merged 1 commit into from Mar 7, 2019
Merged

Fix issues on trusts collection #61

merged 1 commit into from Mar 7, 2019

Conversation

@Crypt0-M3lon
Copy link
Contributor

@Crypt0-M3lon Crypt0-M3lon commented Mar 7, 2019

This is a shorter version of #51 fixing only issue about trusts collections.

When enumerating from a child domain, information about trust in the same forest were wrong:

  • A trust to the domain itself was collected;
  • Trust to the root domain were ignored due to a check in the code, I suppose to ignore trust to itself when enumerating from root domain;
  • Trust with other children were displayed as outbound even without cross-link enable.

The PR fix all these things and add new trust types (CrossLink and Forest trusts).

@rvazarkar
Copy link
Collaborator

@rvazarkar rvazarkar commented Mar 7, 2019

Great work, thanks for the PR

@rvazarkar rvazarkar merged commit efc8ebf into BloodHoundAD:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants