This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
🌸 2.0.0 #43
Open
🌸 2.0.0 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
AoshiW
reviewed
Oct 10, 2023
Co-authored-by: AoshiW <48525283+AoshiW@users.noreply.github.com>
AoshiW
reviewed
Oct 15, 2023
Comment on lines
+19
to
+25
| public ILogger Logger { get; set; } = LoggerFactory | ||
| .Create(c => | ||
| { | ||
| c.AddConsole(); | ||
| c.SetMinimumLevel(LogLevel.Debug); | ||
| }) | ||
| .CreateLogger("RiotBlossom"); |
There was a problem hiding this comment.
I think you should set it to NullLogger, it is better if the user sets it up himself
Currently it has several problems, for example:
- inability to change
LogLevel - inability to remove the current Console Logger
- inability to add another Logger Provider
AoshiW
reviewed
Oct 15, 2023
Comment on lines
+18
to
+24
| protected async override Task<string?> ReadAsync(string key) | ||
| { | ||
| var json = _cache[key]; | ||
|
|
||
| return await Task.FromResult(json) | ||
| .ConfigureAwait(false); | ||
| } |
Comment on lines
+14
to
+18
| protected async override Task<string?> ReadAsync(string key) | ||
| { | ||
| return await Task.FromResult<string?>(null) | ||
| .ConfigureAwait(false); | ||
| } |
| } | ||
| } | ||
|
|
||
| protected abstract Task<string?> ReadAsync(string key); |
There was a problem hiding this comment.
the return type could be ValueTask<string?>
Comment on lines
+11
to
+16
| public async override Task ProcessRequestAsync(DataCall call, HttpRequestMessage req) | ||
| { | ||
| // NO-OP | ||
| await Task.CompletedTask | ||
| .ConfigureAwait(false); | ||
| } |
Comment on lines
+31
to
+33
| var delay = delays | ||
| .OrderByDescending(x => x.Ticks) | ||
| .First(); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be keeping this PR here until I finish it. Should solve issues with rate limiter and library complexity. Will be bumping framework requirement to the upcoming .NET 8 LTS release. 💚