Projections #150
Merged
Projections #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
previously approved these changes
Apr 26, 2017
brion/blueConfig.h
Outdated
|
|
||
| /** | ||
| * @return the full path to the morphology database. A suffix may be | ||
| * prepended to the to the bare path from the BlueConfig. |
tribal-tec
dismissed
their stale review
Hold on. I didn't see the 3rd commit while reviewing...
tribal-tec
reviewed
Apr 26, 2017
brain/circuit.h
Outdated
| * to cells in the projecting circuit. | ||
| * \endif | ||
| */ | ||
| BRAIN_API SynapsesStream getAfferentProjections( |
There was a problem hiding this comment.
we don't get a confusion with the existing getProjectedSynapses() in terms of similar names I hope.
There was a problem hiding this comment.
Difficult to say, if you have a better suggestion it will be welcomed.
brain/detail/synapsesStream.h
Outdated
| _afferent, _prefetch); | ||
| }); | ||
| } | ||
| else |
brain/synapses.cpp
Outdated
| @@ -123,14 +139,18 @@ struct Synapses::Impl : public Synapses::BaseImpl | |||
| return; | |||
|
|
|||
| const brion::Synapse& synapseAttributes = | |||
| _circuit._impl->getSynapseAttributes(_afferent); | |||
| const brion::Synapse* synapseExtra = _circuit._impl->getSynapseExtra(); | |||
| _source.empty() | |||
There was a problem hiding this comment.
rename _source to _externalSource or similar? It's not quite obvious deeply in the code what this means.
hernando
force-pushed
the
projections
branch
2 times, most recently
from
c1ccdec
to
9a7e4f0
Compare
This function gives access to synape data for afferent projections external to the circuit.
tribal-tec
approved these changes
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.