Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Fast membrane current calculation #196

Merged
merged 14 commits into from
Oct 2, 2019
Merged

Fast membrane current calculation #196

merged 14 commits into from
Oct 2, 2019

Conversation

iomaganaris
Copy link
Contributor

@iomaganaris iomaganaris commented Sep 18, 2019

iomaganaris and others added 5 commits September 12, 2019 16:20
- Turned the struct _nrn_Fast_Imem of pointers to double arrays in
  NrnThread
- Moved fast_imem calculation related functions to seperate files
- Related to enabling fast_imem calculation from report parser
- Removed some debugging code
Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/

Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, but a few minor things to change

coreneuron/nrniv/nrn_setup.cpp Show resolved Hide resolved
coreneuron/nrniv/nrn_setup.cpp Outdated Show resolved Hide resolved
coreneuron/nrnoc/fast_imem.cpp Outdated Show resolved Hide resolved
- Added documentation in stdindex2ptr function
- Changed fast_imem (de)allocation functions with "CoreNeuron" for loop
- Small identation fix
@nrnhines
Copy link
Collaborator

retest

@nrnhines
Copy link
Collaborator

Please retest

@nrnhines nrnhines closed this Sep 27, 2019
@nrnhines nrnhines reopened this Sep 27, 2019
Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, overall lgtm.

Could you create ticket to implement GPU support for the same? We don't have to implement that in this PR but good to have issue for this already. It would be good small task to learn OpenACC GPU programming.

coreneuron/nrnoc/fast_imem.cpp Outdated Show resolved Hide resolved
coreneuron/nrnoc/fast_imem.cpp Outdated Show resolved Hide resolved
coreneuron/nrnoc/fast_imem.cpp Outdated Show resolved Hide resolved
coreneuron/nrnoc/multicore.h Outdated Show resolved Hide resolved
coreneuron/nrnoc/fast_imem.cpp Outdated Show resolved Hide resolved
coreneuron/nrnoc/fast_imem.cpp Outdated Show resolved Hide resolved
- Removed unused variables
- Improvements on used variables
- Removed change in mod2c submodule
Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit 8d962da into master Oct 2, 2019
@pramodk pramodk deleted the fast_imem branch October 2, 2019 04:28
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
In order to support i_membrane reports, this PR the functionality of fast membrane calculation from NEURON.
  - Related to enabling fast_imem calculation from report parser (for neurondamus+reportinglib)
  - Added i_membrane to neuron direct memory transfer and refactored
fast_imem memory allocation
  - Updated mod2c submodule commit

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@8d962da
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants