-
Notifications
You must be signed in to change notification settings - Fork 38
Fast membrane current calculation #196
Conversation
- Turned the struct _nrn_Fast_Imem of pointers to double arrays in NrnThread - Moved fast_imem calculation related functions to seperate files
- Related to enabling fast_imem calculation from report parser - Removed some debugging code
fast_imem memory allocation
reports for the fast_imem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/
This reverts commit 2304e9a and adds only the proper files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, but a few minor things to change
- Added documentation in stdindex2ptr function - Changed fast_imem (de)allocation functions with "CoreNeuron" for loop - Small identation fix
retest |
Please retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, overall lgtm.
Could you create ticket to implement GPU support for the same? We don't have to implement that in this PR but good to have issue for this already. It would be good small task to learn OpenACC GPU programming.
- Removed unused variables - Improvements on used variables - Removed change in mod2c submodule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In order to support i_membrane reports, this PR the functionality of fast membrane calculation from NEURON. - Related to enabling fast_imem calculation from report parser (for neurondamus+reportinglib) - Added i_membrane to neuron direct memory transfer and refactored fast_imem memory allocation - Updated mod2c submodule commit CoreNEURON Repo SHA: BlueBrain/CoreNeuron@8d962da
Related to BlueBrain/mod2c#32 and neuronsimulator/nrn#272