Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing #106: fails to open existing file with Create flag #107

Closed
wants to merge 1 commit into from

Conversation

@akheir
Copy link

akheir commented Apr 5, 2018

fix #106: where File file(FILE_NAME, File::ReadWrite | File::Create); failed to open a file when it exists.

This also fixes the test where trigger to file creation conflict is tested.
File file(FILE_NAME, File::ReadWrite | File::Create | File::Excl); should fail when the file exist.
File file(FILE_NAME, File::ReadWrite | File::Create); should just open the file when it exist.

fix the test to trigger file creation conflict
@akheir

This comment has been minimized.

Copy link
Author

akheir commented May 7, 2018

Any updates about merging this pull request?

@ferdonline

This comment has been minimized.

Copy link
Collaborator

ferdonline commented Jun 1, 2018

These problems arise from the fact that different flags are used with H5FCreate or H5FOpen.
To my mind we should encapsulate these details and use higher level flags, like in c++ fstream, but meeting HDF5 specifics (e.g.: no append).
What do you think @adevress ?

@ferdonline

This comment has been minimized.

Copy link
Collaborator

ferdonline commented Jun 4, 2018

Thanks for reporting and suggesting a fix, we then worked on a more complete solution in #114

@ferdonline ferdonline closed this Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.