This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Conversation
Also specify ttf font file type separately to fix issue where path included public/public
dhaneshnm
approved these changes
Dec 1, 2021
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M3 #1000 +/- ##
===========================================
Coverage ? 66.00%
===========================================
Files ? 21
Lines ? 609
Branches ? 137
===========================================
Hits ? 402
Misses ? 207
Partials ? 0 Continue to review full report at Codecov.
|
smitfire
approved these changes
Dec 1, 2021
dhaneshnm
pushed a commit
that referenced
this pull request
Dec 9, 2021
Also specify ttf font file type separately to fix issue where path included public/public Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
dhaneshnm
pushed a commit
that referenced
this pull request
Mar 11, 2022
Also specify ttf font file type separately to fix issue where path included public/public Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BlueBrain/nexus#2969
Description
PDF viewer was only working in dev. In dev/staging/production the pdf worker file could not be found.
Changed webpack config to copy pdfjs worker file to public directory. Specify this path for the worker.
Also specify ttf font file type separately to fix issue where path included public/public
How has this been tested?
Built for production and hosted locally to test. Confirmed the pdf worker file now loads and the pdf viewer works as expected.
Types of changes
Checklist: