Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search filter bug condition #1003

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Search filter bug condition #1003

merged 2 commits into from
Dec 8, 2021

Conversation

smitfire
Copy link
Contributor

@smitfire smitfire commented Dec 8, 2021

Fixes #
Search used to crash with small js bug when some of the fields passed certain conditions but still had issues.

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

Codecov Report

Merging #1003 (0dc95d4) into main (5007a23) will decrease coverage by 1.06%.
The diff coverage is 52.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1003      +/-   ##
==========================================
- Coverage   67.07%   66.00%   -1.07%     
==========================================
  Files          21       21              
  Lines         568      609      +41     
  Branches      126      126              
==========================================
+ Hits          381      402      +21     
- Misses        187      207      +20     
Impacted Files Coverage Δ
src/shared/utils/stringSimilarity.ts 56.25% <22.22%> (-43.75%) ⬇️
src/shared/utils/index.ts 71.96% <60.60%> (-2.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd4bac...0dc95d4. Read the comment docs.

@smitfire smitfire changed the base branch from main to 1.7.0-M3 December 8, 2021 13:13
@dhaneshnm dhaneshnm self-requested a review December 8, 2021 13:46
@dhaneshnm dhaneshnm merged commit 83f48f2 into 1.7.0-M3 Dec 8, 2021
@dhaneshnm dhaneshnm deleted the srch0bug branch December 8, 2021 13:48
dhaneshnm pushed a commit that referenced this pull request Dec 14, 2021
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants