Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Persist open/close state of plugins#1004

Merged
dhaneshnm merged 2 commits into1.7.0-M3from
2942-save-open-close-state-of-plugin
Dec 13, 2021
Merged

Persist open/close state of plugins#1004
dhaneshnm merged 2 commits into1.7.0-M3from
2942-save-open-close-state-of-plugin

Conversation

@nicwells
Copy link
Copy Markdown
Contributor

Fixes BlueBrain/nexus#2942

Description

Persist open/close state of plugins in local storage. If a resource has a plugin open then viewing another resource will also show that plugin open (assuming it has the plugin), this applies to multiple too. Opening resources that do not have certain plugins with an open state won't have any effect, i.e. they will show as open on the next resource with that plugin.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@dd4eedf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1004   +/-   ##
===========================================
  Coverage            ?   66.00%           
===========================================
  Files               ?       21           
  Lines               ?      609           
  Branches            ?      126           
===========================================
  Hits                ?      402           
  Misses              ?      207           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4eedf...36bf05e. Read the comment docs.

@dhaneshnm dhaneshnm merged commit 5a37683 into 1.7.0-M3 Dec 13, 2021
@dhaneshnm dhaneshnm deleted the 2942-save-open-close-state-of-plugin branch December 13, 2021 10:31
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants