Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support composite views in data tables #1006

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#2945

Description

  • Use data table component in Studios instead of sparql view directly
  • Enable specifying a projection or all projections
  • New studios are created with new components. Existing studios continue
    to use old components but will display message prompting to upgrade.
  • A script will be made available to migrate old studios to new studios
    or alternatively the user can manually create a new studio

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

* Use data table component in Studios instead of sparql view directly
* Enable specifying a projection or all projections
* New studios are created with new components. Existing studios continue
to use old components but will display message prompting to upgrade.
* A script will be made available to migrate old studios to new studios
or alternatively the user can manually create a new studio
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@eeab095). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1006   +/-   ##
===========================================
  Coverage            ?   65.95%           
===========================================
  Files               ?       21           
  Lines               ?      611           
  Branches            ?      126           
===========================================
  Hits                ?      403           
  Misses              ?      208           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeab095...0a6cc42. Read the comment docs.

@dhaneshnm dhaneshnm merged commit 8bcea07 into 1.7.0-M3 Dec 16, 2021
@dhaneshnm dhaneshnm deleted the 2748-merge-compositeviews branch December 16, 2021 15:11
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Use data table component in Studios instead of sparql view directly
* Enable specifying a projection or all projections
* New studios are created with new components. Existing studios continue
to use old components but will display message prompting to upgrade.
* A script will be made available to migrate old studios to new studios
or alternatively the user can manually create a new studio

Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants