Fix creation of resources list from "copy resource list" shortcut link #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M3 #1012 +/- ##
===========================================
Coverage ? 65.95%
===========================================
Files ? 21
Lines ? 611
Branches ? 126
===========================================
Hits ? 403
Misses ? 208
Partials ? 0 Continue to review full report at Codecov.
|
dhaneshnm
approved these changes
Jan 4, 2022
smitfire
added a commit
that referenced
this pull request
Jan 10, 2022
…to 2938-nums * '2938-nums' of https://github.com/BlueBrain/nexus-web: 2986 fix styles (#1015) Add redirect params to login call back (#1014) 2644 allow user to select search config (#1011) Rewrite useLocalStorage hook and make use of (#1012)
dhaneshnm
pushed a commit
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BlueBrain/nexus#2985
Description
The functionality where a user can copy a shortcut to a resources list and share with others was broken. When
the link was visited the new resources list would get overwritten. Rewrote the useLocalStorage hook that was being used to make it work with async code as expected.
How has this been tested?
Types of changes
Checklist: