Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Add redirect params to login call back#1014

Merged
dhaneshnm merged 4 commits into1.7.0-M3from
2328-redirect-params
Jan 4, 2022
Merged

Add redirect params to login call back#1014
dhaneshnm merged 4 commits into1.7.0-M3from
2328-redirect-params

Conversation

@dhaneshnm
Copy link
Copy Markdown
Contributor

Fixes BlueBrain/nexus/issues/2328

Description

When a user logins in using the right top login button, after login , the user is redirected to the path they started from. eg: if they were on a studio, they land back on that studio.

How has this been tested?

Manual testing. Go to a studio url (with out logging in ), then log in using the button on right top, you should be redirected to the page you started at.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@dhaneshnm dhaneshnm requested review from nicwells and smitfire January 4, 2022 08:43
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@8c262fc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1014   +/-   ##
===========================================
  Coverage            ?   65.95%           
===========================================
  Files               ?       21           
  Lines               ?      611           
  Branches            ?      126           
===========================================
  Hits                ?      403           
  Misses              ?      208           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c262fc...96c74d6. Read the comment docs.

@dhaneshnm dhaneshnm merged commit 034f391 into 1.7.0-M3 Jan 4, 2022
@dhaneshnm dhaneshnm deleted the 2328-redirect-params branch January 4, 2022 11:19
smitfire added a commit that referenced this pull request Jan 10, 2022
…to 2938-nums

* '2938-nums' of https://github.com/BlueBrain/nexus-web:
  2986 fix styles (#1015)
  Add redirect params to login call back (#1014)
  2644 allow user to select search config (#1011)
  Rewrite useLocalStorage hook and make use of (#1012)
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Add redirect params to login call back
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants