Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

2835 Search bar text and searching for things with same value as project or studio #1020

Merged
merged 2 commits into from
Jan 11, 2022
Merged

2835 Search bar text and searching for things with same value as project or studio #1020

merged 2 commits into from
Jan 11, 2022

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#2835

Description

  • When not in search view, search bar is empty and when clicked remains empty.
  • When user searches for text that matches project or studio name it should still search rather than navigate to the project/studio.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@nicwells nicwells changed the title 2835 search bar text 2835 Search bar text and searching for things with same value as project or studio Jan 11, 2022
@nicwells nicwells force-pushed the 2835-search-bar-text branch from 37d1620 to 6df0b80 Compare January 11, 2022 11:11
@dhaneshnm dhaneshnm merged commit 22dd24c into 1.7.0-M3 Jan 11, 2022
@dhaneshnm dhaneshnm deleted the 2835-search-bar-text branch January 11, 2022 14:06
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
@nicwells @dhaneshnm
2835 Search bar text and searching for things with same value as proj…
4095881 
…ect or studio (#1020)

* Search bar empty when clicked outside of search

* Fix bug where cannot search for text which matches project/studio
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhaneshnm dhaneshnm dhaneshnm approved these changes

@smitfire smitfire Awaiting requested review from smitfire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicwells @dhaneshnm