Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

More specific css rules and fix at same time#1021

Merged
dhaneshnm merged 1 commit into1.7.0-M3from
2987-settings-pane-styling-issues
Jan 12, 2022
Merged

More specific css rules and fix at same time#1021
dhaneshnm merged 1 commit into1.7.0-M3from
2987-settings-pane-styling-issues

Conversation

@nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#2987

Description

Fixes layout issue caused by generic css rule intended for another component, FilterOptions. Improved styling of FilterOptions at same time.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@22dd24c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1021   +/-   ##
===========================================
  Coverage            ?   65.15%           
===========================================
  Files               ?       22           
  Lines               ?      640           
  Branches            ?      131           
===========================================
  Hits                ?      417           
  Misses              ?      223           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22dd24c...25e844a. Read the comment docs.

@dhaneshnm dhaneshnm merged commit a04d7bf into 1.7.0-M3 Jan 12, 2022
@dhaneshnm dhaneshnm deleted the 2987-settings-pane-styling-issues branch January 12, 2022 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants